2016-11-22 17:10:49

by Stanimir Varbanov

Subject: [PATCH 1/3] remoteproc: qcom: mdt_loader: add include for sizes

Add linux/sizes.h to prevent build failure on non ARM architectures
as:

CC [M] drivers/remoteproc/qcom_mdt_loader.o
In file included from include/linux/cache.h:4:0,
from include/linux/printk.h:8,
from include/linux/kernel.h:13,
from include/asm-generic/bug.h:13,
from arch/x86/include/asm/bug.h:35,
from include/linux/bug.h:4,
from include/linux/thread_info.h:11,
from arch/x86/include/asm/elf.h:7,
from include/linux/elf.h:4,
from drivers/remoteproc/qcom_mdt_loader.c:18:
drivers/remoteproc/qcom_mdt_loader.c: In function ‘qcom_mdt_parse’:
drivers/remoteproc/qcom_mdt_loader.c:90:52: error: ‘SZ_4K’ undeclared
(first use in this function)

Signed-off-by: Stanimir Varbanov <[email protected]>
---
drivers/remoteproc/qcom_mdt_loader.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_mdt_loader.c b/drivers/remoteproc/qcom_mdt_loader.c
index 114e8e4cef67..2ff18cd6c096 100644
--- a/drivers/remoteproc/qcom_mdt_loader.c
+++ b/drivers/remoteproc/qcom_mdt_loader.c
@@ -20,6 +20,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/remoteproc.h>
+#include <linux/sizes.h>
#include <linux/slab.h>

#include "remoteproc_internal.h"
--
2.7.4

2016-11-23 22:48:22

by Stephen Boyd

Subject: Re: [PATCH 1/3] remoteproc: qcom: mdt_loader: add include for sizes

On 11/22, Stanimir Varbanov wrote:
> Add linux/sizes.h to prevent build failure on non ARM architectures
> as:
>
> CC [M] drivers/remoteproc/qcom_mdt_loader.o
> In file included from include/linux/cache.h:4:0,
> from include/linux/printk.h:8,
> from include/linux/kernel.h:13,
> from include/asm-generic/bug.h:13,
> from arch/x86/include/asm/bug.h:35,
> from include/linux/bug.h:4,
> from include/linux/thread_info.h:11,
> from arch/x86/include/asm/elf.h:7,
> from include/linux/elf.h:4,
> from drivers/remoteproc/qcom_mdt_loader.c:18:
> drivers/remoteproc/qcom_mdt_loader.c: In function ‘qcom_mdt_parse’:
> drivers/remoteproc/qcom_mdt_loader.c:90:52: error: ‘SZ_4K’ undeclared
> (first use in this function)
>
> Signed-off-by: Stanimir Varbanov <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2016-12-03 04:49:34

by Bjorn Andersson

Subject: Re: [PATCH 1/3] remoteproc: qcom: mdt_loader: add include for sizes

On Tue 22 Nov 09:02 PST 2016, Stanimir Varbanov wrote:

> Add linux/sizes.h to prevent build failure on non ARM architectures
> as:
>
> CC [M] drivers/remoteproc/qcom_mdt_loader.o
> In file included from include/linux/cache.h:4:0,
> from include/linux/printk.h:8,
> from include/linux/kernel.h:13,
> from include/asm-generic/bug.h:13,
> from arch/x86/include/asm/bug.h:35,
> from include/linux/bug.h:4,
> from include/linux/thread_info.h:11,
> from arch/x86/include/asm/elf.h:7,
> from include/linux/elf.h:4,
> from drivers/remoteproc/qcom_mdt_loader.c:18:
> drivers/remoteproc/qcom_mdt_loader.c: In function ?qcom_mdt_parse?:
> drivers/remoteproc/qcom_mdt_loader.c:90:52: error: ?SZ_4K? undeclared
> (first use in this function)
>
> Signed-off-by: Stanimir Varbanov <[email protected]>

Applied

Thanks,
Bjorn

> ---
> drivers/remoteproc/qcom_mdt_loader.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_mdt_loader.c b/drivers/remoteproc/qcom_mdt_loader.c
> index 114e8e4cef67..2ff18cd6c096 100644
> --- a/drivers/remoteproc/qcom_mdt_loader.c
> +++ b/drivers/remoteproc/qcom_mdt_loader.c
> @@ -20,6 +20,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/remoteproc.h>
> +#include <linux/sizes.h>
> #include <linux/slab.h>
>
> #include "remoteproc_internal.h"
> --
> 2.7.4
>