2016-12-04 13:12:24

by Jorik Jonker

[permalink] [raw]
Subject: [PATCH] dts: sun8i-h3: correct UART3 pin definitions

From: Jorik Jonker <[email protected]>

In a previous commit, I made a copy/paste error in the pinmux
definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
care of that. I have tested this commit on Orange Pi PC and Orange Pi
Plus, and it works for these boards.

Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
UART2-3")

Signed-off-by: Jorik Jonker <[email protected]>
---
arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 75a8654..f4ba088 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -410,7 +410,7 @@
};

uart3_pins: uart3 {
- allwinner,pins = "PG13", "PG14";
+ allwinner,pins = "PA13", "PA14";
allwinner,function = "uart3";
allwinner,drive = <SUN4I_PINCTRL_10_MA>;
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
--
2.9.3


2016-12-06 14:06:08

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] dts: sun8i-h3: correct UART3 pin definitions

Hi Jorik,

On Sun, Dec 04, 2016 at 01:29:48PM +0100, [email protected] wrote:
> From: Jorik Jonker <[email protected]>
>
> In a previous commit, I made a copy/paste error in the pinmux
> definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
> care of that. I have tested this commit on Orange Pi PC and Orange Pi
> Plus, and it works for these boards.
>
> Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
> UART2-3")
>
> Signed-off-by: Jorik Jonker <[email protected]>

Thanks!

This looks like a late fix for the current release which comes to an
end. Can you resend it with [email protected] as a recipient, so that the
ARM SoC maintainers can apply it directly?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


Attachments:
(No filename) (814.00 B)
signature.asc (801.00 B)
Download all attachments

2016-12-06 14:31:57

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] dts: sun8i-h3: correct UART3 pin definitions

Hi Arnd, Olof,

On Tue, Dec 06, 2016 at 03:27:10PM +0100, [email protected] wrote:
> From: Jorik Jonker <[email protected]>
>
> In a previous commit, I made a copy/paste error in the pinmux
> definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes
> care of that. I have tested this commit on Orange Pi PC and Orange Pi
> Plus, and it works for these boards.
>
> Fixes: e3d11d3c45c5 ("dts: sun8i-h3: add pinmux definitions for
> UART2-3")
>
> Signed-off-by: Jorik Jonker <[email protected]>

Could you please queue that patch for 4.9, with
Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


Attachments:
(No filename) (742.00 B)
signature.asc (801.00 B)
Download all attachments