2016-12-15 15:29:17

by Corentin Labbe

Subject: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

hid/intel-ish-hid does not use any miscdevice so this patch remove
this unnecessary inclusion.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
drivers/hid/intel-ish-hid/ishtp/hbm.c | 1 -
drivers/hid/intel-ish-hid/ishtp/init.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index 20d647d..d20da39 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -24,7 +24,6 @@
#include <linux/sched.h>
#include <linux/interrupt.h>
#include <linux/workqueue.h>
-#include <linux/miscdevice.h>
#define CREATE_TRACE_POINTS
#include <trace/events/intel_ish.h>
#include "ishtp-dev.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c
index 59460b6..b721360 100644
--- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
+++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
@@ -19,7 +19,6 @@
#include <linux/sched.h>
#include <linux/wait.h>
#include <linux/spinlock.h>
-#include <linux/miscdevice.h>
#include "ishtp-dev.h"
#include "hbm.h"
#include "client.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c b/drivers/hid/intel-ish-hid/ishtp/init.c
index ac36441..d27e035 100644
--- a/drivers/hid/intel-ish-hid/ishtp/init.c
+++ b/drivers/hid/intel-ish-hid/ishtp/init.c
@@ -16,7 +16,6 @@
#include <linux/export.h>
#include <linux/slab.h>
#include <linux/sched.h>
-#include <linux/miscdevice.h>
#include "ishtp-dev.h"
#include "hbm.h"
#include "client.h"
--
2.10.2

2016-12-15 16:20:48

by srinivas pandruvada

Subject: Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

On Thu, 2016-12-15 at 16:27 +0100, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
>  drivers/hid/intel-ish-hid/ishtp/hbm.c   | 1 -
>  drivers/hid/intel-ish-hid/ishtp/init.c  | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 20d647d..d20da39 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -24,7 +24,6 @@
>  #include <linux/sched.h>
>  #include <linux/interrupt.h>
>  #include <linux/workqueue.h>
> -#include <linux/miscdevice.h>
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/intel_ish.h>
>  #include "ishtp-dev.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> index 59460b6..b721360 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> @@ -19,7 +19,6 @@
>  #include <linux/sched.h>
>  #include <linux/wait.h>
>  #include <linux/spinlock.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c
> b/drivers/hid/intel-ish-hid/ishtp/init.c
> index ac36441..d27e035 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/init.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/init.c
> @@ -16,7 +16,6 @@
>  #include <linux/export.h>
>  #include <linux/slab.h>
>  #include <linux/sched.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"

2016-12-19 10:17:41

by Jiri Kosina

Subject: Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

On Thu, 15 Dec 2016, Corentin Labbe wrote:

> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Applied, thanks.

--
Jiri Kosina
SUSE Labs