2016-12-15 18:10:28

by Corentin Labbe

Subject: [PATCH] hwmon: sch56xx: Remove unneeded linux/miscdevice.h include

drivers/hwmon/sch56xx-common.c does not contain any miscdevice so the
inclusion of linux/miscdevice.h is uncessary.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/hwmon/sch56xx-common.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
index 68c350c..bda3d52 100644
--- a/drivers/hwmon/sch56xx-common.c
+++ b/drivers/hwmon/sch56xx-common.c
@@ -28,7 +28,6 @@
#include <linux/delay.h>
#include <linux/fs.h>
#include <linux/watchdog.h>
-#include <linux/miscdevice.h>
#include <linux/uaccess.h>
#include <linux/slab.h>
#include "sch56xx-common.h"
--
2.10.2

2016-12-16 03:36:03

by Guenter Roeck

Subject: Re: [PATCH] hwmon: sch56xx: Remove unneeded linux/miscdevice.h include

On 12/15/2016 10:08 AM, Corentin Labbe wrote:
> drivers/hwmon/sch56xx-common.c does not contain any miscdevice so the
> inclusion of linux/miscdevice.h is uncessary.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/hwmon/sch56xx-common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
> index 68c350c..bda3d52 100644
> --- a/drivers/hwmon/sch56xx-common.c
> +++ b/drivers/hwmon/sch56xx-common.c
> @@ -28,7 +28,6 @@
> #include <linux/delay.h>
> #include <linux/fs.h>
> #include <linux/watchdog.h>
> -#include <linux/miscdevice.h>
> #include <linux/uaccess.h>
> #include <linux/slab.h>
> #include "sch56xx-common.h"
>