2016-12-17 00:29:42

by Jérémy Lefaure

Subject: [PATCH] irqchip: st: fix defined but not used compilation warning

When CONFIG_PM_SLEEP is disabled, the compiler raises a warning on
st_irq_syscfg_resume:

drivers/irqchip/irq-st.c:183:12: warning: 'st_irq_syscfg_resume' defined
but not used [-Wunused-function]
static int st_irq_syscfg_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~

Adding __maybe_unused to the declaration of this functions removes the
warning.

Signed-off-by: Jérémy Lefaure <[email protected]>
---
drivers/irqchip/irq-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
index 9af48a85c16f..5e0e250db0be 100644
--- a/drivers/irqchip/irq-st.c
+++ b/drivers/irqchip/irq-st.c
@@ -180,7 +180,7 @@ static int st_irq_syscfg_probe(struct platform_device *pdev)
return st_irq_syscfg_enable(pdev);
}

-static int st_irq_syscfg_resume(struct device *dev)
+static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
{
struct st_irq_syscfg *ddata = dev_get_drvdata(dev);

--
2.11.0

2016-12-19 10:01:16

by tip-bot for Vasyl Gomonovych

Subject: [tip:irq/urgent] irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused

Commit-ID: f357563f958df06cd9ea9e614cdba30578bb08b1
Gitweb: http://git.kernel.org/tip/f357563f958df06cd9ea9e614cdba30578bb08b1
Author: Jérémy Lefaure <[email protected]>
AuthorDate: Fri, 16 Dec 2016 19:29:27 -0500
Committer: Thomas Gleixner <[email protected]>
CommitDate: Mon, 19 Dec 2016 10:55:43 +0100

irqchip/st: Mark st_irq_syscfg_resume() __maybe_unused

When CONFIG_PM_SLEEP is disabled, the compiler raises a warning on
st_irq_syscfg_resume:

drivers/irqchip/irq-st.c:183:12: warning: 'st_irq_syscfg_resume' defined
but not used [-Wunused-function]
static int st_irq_syscfg_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~

Annotate the function with __maybe_unused.

Signed-off-by: Jérémy Lefaure <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: Jason Cooper <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>

---
drivers/irqchip/irq-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
index 9af48a8..5e0e250 100644
--- a/drivers/irqchip/irq-st.c
+++ b/drivers/irqchip/irq-st.c
@@ -180,7 +180,7 @@ static int st_irq_syscfg_probe(struct platform_device *pdev)
return st_irq_syscfg_enable(pdev);
}

-static int st_irq_syscfg_resume(struct device *dev)
+static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
{
struct st_irq_syscfg *ddata = dev_get_drvdata(dev);