2016-12-16 14:54:50

by Michał Kępień

Subject: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

The "radio components indicator" LED present in Lifebook E734/E744/E754
should be lit when any radio transmitter is enabled, so set its default
trigger to rfkill-any.

Signed-off-by: Michał Kępień <[email protected]>
---
Note: the rfkill-any trigger is currently only present in
mac80211-next/master.

drivers/platform/x86/fujitsu-laptop.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 61f39ab..bfc0eb3 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,

static struct led_classdev radio_led = {
.name = "fujitsu::radio_led",
+ .default_trigger = "rfkill-any",
.brightness_get = radio_led_get,
.brightness_set = radio_led_set
};
--
2.10.2

2016-12-17 01:38:21

by Jonathan Woithe

Subject: Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

On Fri, Dec 16, 2016 at 03:46:03PM +0100, Micha?? K??pie?? wrote:
> The "radio components indicator" LED present in Lifebook E734/E744/E754
> should be lit when any radio transmitter is enabled, so set its default
> trigger to rfkill-any.

This shouldn't cause any problems. At the end of the day it's only the
default; if for some reason it's inappropriate for any systems we could do
an override.

Acked-by: Jonathan Woithe <[email protected]>

> Signed-off-by: Micha?? K??pie?? <[email protected]>
> ---
> Note: the rfkill-any trigger is currently only present in
> mac80211-next/master.
>
> drivers/platform/x86/fujitsu-laptop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 61f39ab..bfc0eb3 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
>
> static struct led_classdev radio_led = {
> .name = "fujitsu::radio_led",
> + .default_trigger = "rfkill-any",
> .brightness_get = radio_led_get,
> .brightness_set = radio_led_set
> };

2016-12-27 11:51:39

by Andy Shevchenko

Subject: Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

On Fri, Dec 16, 2016 at 4:46 PM, Michał Kępień <[email protected]> wrote:
> The "radio components indicator" LED present in Lifebook E734/E744/E754
> should be lit when any radio transmitter is enabled, so set its default
> trigger to rfkill-any.
>

Pushed to testing, thanks!

> Signed-off-by: Michał Kępień <[email protected]>
> ---
> Note: the rfkill-any trigger is currently only present in
> mac80211-next/master.
>
> drivers/platform/x86/fujitsu-laptop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 61f39ab..bfc0eb3 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
>
> static struct led_classdev radio_led = {
> .name = "fujitsu::radio_led",
> + .default_trigger = "rfkill-any",
> .brightness_get = radio_led_get,
> .brightness_set = radio_led_set
> };
> --
> 2.10.2
>



--
With Best Regards,
Andy Shevchenko