2016-12-26 17:48:20

by Emmanuel Vadot

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: sunxi: Add num-cs for A20 spi nodes

The spi0 controller on the A20 have up to 4 CS (Chip Select) while the
others three only have 1.
Add the num-cs property to each node.
The current driver doesn't read this property but this is useful for
downstream user of DTS (FreeBSD for example).

Signed-off-by: Emmanuel Vadot <[email protected]>
---

Changes in v2:
* Explain that driver doesn't support this but that it is useful
for downstream users of DTS.

arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 94cf5a1c7172..ed21982c81cb 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -871,6 +871,7 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+ num-cs = 4;
};

spi1: spi@01c06000 {
@@ -885,6 +886,7 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+ num-cs = 1;
};

emac: ethernet@01c0b000 {
@@ -1037,6 +1039,7 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+ num-cs = 1;
};

ahci: sata@01c18000 {
@@ -1079,6 +1082,7 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+ num-cs = 1;
};

pio: pinctrl@01c20800 {
--
2.11.0


2016-12-26 19:35:19

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add num-cs for A20 spi nodes

Hi Emmanuel,

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Emmanuel-Vadot/ARM-dts-sunxi-Add-num-cs-for-A20-spi-nodes/20161227-015214
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/sun7i-a20.dtsi:874.13-14 syntax error
FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


Attachments:
(No filename) (1.06 kB)
.config.gz (21.27 kB)
Download all attachments

2016-12-27 02:12:18

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add num-cs for A20 spi nodes

Hi,

On Tue, Dec 27, 2016 at 1:47 AM, Emmanuel Vadot <[email protected]> wrote:
> The spi0 controller on the A20 have up to 4 CS (Chip Select) while the
> others three only have 1.
> Add the num-cs property to each node.
> The current driver doesn't read this property but this is useful for
> downstream user of DTS (FreeBSD for example).
>
> Signed-off-by: Emmanuel Vadot <[email protected]>
> ---
>
> Changes in v2:
> * Explain that driver doesn't support this but that it is useful
> for downstream users of DTS.
>
> arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 94cf5a1c7172..ed21982c81cb 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -871,6 +871,7 @@
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> + num-cs = 4;

The numbers need to be enclosed in angle brackets.

ChenYu

> };
>
> spi1: spi@01c06000 {
> @@ -885,6 +886,7 @@
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> + num-cs = 1;
> };
>
> emac: ethernet@01c0b000 {
> @@ -1037,6 +1039,7 @@
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> + num-cs = 1;
> };
>
> ahci: sata@01c18000 {
> @@ -1079,6 +1082,7 @@
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> + num-cs = 1;
> };
>
> pio: pinctrl@01c20800 {
> --
> 2.11.0
>