2017-03-08 15:51:35

by Corentin Labbe

Subject: [PATCH] tun: remove copyright printing

Printing copyright does not give any useful information on the boot
process.
Furthermore, the email address printed is obsolete since
commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries")

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/net/tun.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index dc1b1dd..f58b7d8 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -2570,7 +2570,6 @@ static int __init tun_init(void)
int ret = 0;

pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION);
- pr_info("%s\n", DRV_COPYRIGHT);

ret = rtnl_link_register(&tun_link_ops);
if (ret) {
--
2.10.2

2017-03-08 23:50:48

by Stephen Hemminger

Subject: Re: [PATCH] tun: remove copyright printing

On Wed, 8 Mar 2017 16:46:57 +0100
Corentin Labbe <[email protected]> wrote:

> Printing copyright does not give any useful information on the boot
> process.
> Furthermore, the email address printed is obsolete since
> commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries")
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/net/tun.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index dc1b1dd..f58b7d8 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -2570,7 +2570,6 @@ static int __init tun_init(void)
> int ret = 0;
>
> pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION);
> - pr_info("%s\n", DRV_COPYRIGHT);
>
> ret = rtnl_link_register(&tun_link_ops);
> if (ret) {

Why not just kill the pr_info() all together.
It is just a vanity message.

2017-03-10 01:23:19

by David Miller

Subject: Re: [PATCH] tun: remove copyright printing

From: Corentin Labbe <[email protected]>
Date: Wed, 8 Mar 2017 16:46:57 +0100

> Printing copyright does not give any useful information on the boot
> process.
> Furthermore, the email address printed is obsolete since
> commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries")
>
> Signed-off-by: Corentin Labbe <[email protected]>

Applied, thanks.