2017-03-13 11:49:32

by Du, Changbin

Subject: [PATCH] perf: fix typo in function switch_data_file

From: Changbin Du <[email protected]>

Should clear buf abs_path, not options.

Signed-off-by: Changbin Du <[email protected]>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index a6dae80..6fafe02 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2350,7 +2350,7 @@ static int switch_data_file(void)
return ret;

memset(options, 0, sizeof(options));
- memset(options, 0, sizeof(abs_path));
+ memset(abs_path, 0, sizeof(abs_path));

while ((dent = readdir(pwd_dir))) {
char path[PATH_MAX];
--
2.7.4

2017-03-13 15:01:07

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: fix typo in function switch_data_file

Em Mon, Mar 13, 2017 at 07:46:52PM +0800, [email protected] escreveu:
> From: Changbin Du <[email protected]>
>
> Should clear buf abs_path, not options.

Thanks, applied.

- Arnaldo

> Signed-off-by: Changbin Du <[email protected]>
> ---
> tools/perf/ui/browsers/hists.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index a6dae80..6fafe02 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2350,7 +2350,7 @@ static int switch_data_file(void)
> return ret;
>
> memset(options, 0, sizeof(options));
> - memset(options, 0, sizeof(abs_path));
> + memset(abs_path, 0, sizeof(abs_path));
>
> while ((dent = readdir(pwd_dir))) {
> char path[PATH_MAX];
> --
> 2.7.4

2017-03-15 18:43:42

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf hists browser: Fix typo in function switch_data_file

Commit-ID: 3ef5b4023c64c16c793a066a7a2ed6ea3767e0d7
Gitweb: http://git.kernel.org/tip/3ef5b4023c64c16c793a066a7a2ed6ea3767e0d7
Author: Changbin Du <[email protected]>
AuthorDate: Mon, 13 Mar 2017 19:46:52 +0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 13 Mar 2017 11:58:57 -0300

perf hists browser: Fix typo in function switch_data_file

Should clear buf 'abs_path', not 'options'.

Signed-off-by: Changbin Du <[email protected]>
Cc: Feng Tang <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Fixes: 341487ab561f ("perf hists browser: Add option for runtime switching perf data file")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index fc4fb66..2dc82be 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2308,7 +2308,7 @@ static int switch_data_file(void)
return ret;

memset(options, 0, sizeof(options));
- memset(options, 0, sizeof(abs_path));
+ memset(abs_path, 0, sizeof(abs_path));

while ((dent = readdir(pwd_dir))) {
char path[PATH_MAX];