2017-03-14 09:57:37

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Mon, 20 Feb 2017, Baolin Wang wrote:

[...]

> drivers/power/supply/wm831x_power.c | 63 +++
> drivers/usb/gadget/Kconfig | 8 +
> drivers/usb/gadget/udc/Makefile | 1 +
> drivers/usb/gadget/udc/charger.c | 865 +++++++++++++++++++++++++++++++++++
> drivers/usb/gadget/udc/core.c | 19 +-
> include/linux/usb/charger.h | 176 +++++++
> include/linux/usb/gadget.h | 3 +
> include/uapi/linux/usb/charger.h | 31 ++
> 8 files changed, 1165 insertions(+), 1 deletion(-)
> create mode 100644 drivers/usb/gadget/udc/charger.c
> create mode 100644 include/linux/usb/charger.h
> create mode 100644 include/uapi/linux/usb/charger.h

Why have you sent this set to me?

Please be careful when submitting patches, since a lot of us have
enough mail to contend with already.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


2017-03-14 10:39:25

by Baolin Wang

[permalink] [raw]
Subject: Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi,

On 14 March 2017 at 17:57, Lee Jones <[email protected]> wrote:
> On Mon, 20 Feb 2017, Baolin Wang wrote:
>
> [...]
>
>> drivers/power/supply/wm831x_power.c | 63 +++
>> drivers/usb/gadget/Kconfig | 8 +
>> drivers/usb/gadget/udc/Makefile | 1 +
>> drivers/usb/gadget/udc/charger.c | 865 +++++++++++++++++++++++++++++++++++
>> drivers/usb/gadget/udc/core.c | 19 +-
>> include/linux/usb/charger.h | 176 +++++++
>> include/linux/usb/gadget.h | 3 +
>> include/uapi/linux/usb/charger.h | 31 ++
>> 8 files changed, 1165 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/usb/gadget/udc/charger.c
>> create mode 100644 include/linux/usb/charger.h
>> create mode 100644 include/uapi/linux/usb/charger.h
>
> Why have you sent this set to me?

Since you have one ack on patch 4, I think I need CC you. But If you
are not interested in this patchset, I will not CC you next time.
Sorry.

[PATCH v19 4/4] power: wm831x_power: Support USB charger current limit
management

Integrate with the newly added USB charger interface to limit the current
we draw from the USB input based on the input device configuration
identified by the USB stack, allowing us to charge more quickly from high
current inputs without drawing more current than specified from others.

Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Baolin Wang <[email protected]>
Acked-by: Lee Jones <[email protected]>
Acked-by: Charles Keepax <[email protected]>
Acked-by: Peter Chen <[email protected]>
Acked-by: Sebastian Reichel <[email protected]>
.......

--
Baolin.wang
Best Regards

2017-03-14 12:14:23

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Tue, 14 Mar 2017, Baolin Wang wrote:

> Hi,
>
> On 14 March 2017 at 17:57, Lee Jones <[email protected]> wrote:
> > On Mon, 20 Feb 2017, Baolin Wang wrote:
> >
> > [...]
> >
> >> drivers/power/supply/wm831x_power.c | 63 +++
> >> drivers/usb/gadget/Kconfig | 8 +
> >> drivers/usb/gadget/udc/Makefile | 1 +
> >> drivers/usb/gadget/udc/charger.c | 865 +++++++++++++++++++++++++++++++++++
> >> drivers/usb/gadget/udc/core.c | 19 +-
> >> include/linux/usb/charger.h | 176 +++++++
> >> include/linux/usb/gadget.h | 3 +
> >> include/uapi/linux/usb/charger.h | 31 ++
> >> 8 files changed, 1165 insertions(+), 1 deletion(-)
> >> create mode 100644 drivers/usb/gadget/udc/charger.c
> >> create mode 100644 include/linux/usb/charger.h
> >> create mode 100644 include/uapi/linux/usb/charger.h
> >
> > Why have you sent this set to me?
>
> Since you have one ack on patch 4, I think I need CC you. But If you
> are not interested in this patchset, I will not CC you next time.
> Sorry.

I Acked one of the patches 9 months ago since it contained an MFD
change.

Yes, if you could drop me from any new submissions, that'd be great,
thanks.

> [PATCH v19 4/4] power: wm831x_power: Support USB charger current limit
> management
>
> Integrate with the newly added USB charger interface to limit the current
> we draw from the USB input based on the input device configuration
> identified by the USB stack, allowing us to charge more quickly from high
> current inputs without drawing more current than specified from others.
>
> Signed-off-by: Mark Brown <[email protected]>
> Signed-off-by: Baolin Wang <[email protected]>
> Acked-by: Lee Jones <[email protected]>
> Acked-by: Charles Keepax <[email protected]>
> Acked-by: Peter Chen <[email protected]>
> Acked-by: Sebastian Reichel <[email protected]>
> .......
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog