2017-03-13 14:46:07

by Stafford Horne

Subject: [PATCH v2] generic syscalls: Wire up statx syscall

The new syscall statx is implemented as generic code, so enable it
for architectures like openrisc which use the generic syscall table.

Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
Cc: Thomas Gleixner <[email protected]>
Cc: Al Viro <[email protected]>
Cc: David Howells <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: [email protected]
Signed-off-by: Stafford Horne <[email protected]>
---
Change in v2:
- Add a few more Cc's to get attention of the right people
- Add a fixes tag for better audit

include/uapi/asm-generic/unistd.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 9b1462e..a076cf1 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -730,9 +730,11 @@ __SYSCALL(__NR_pkey_mprotect, sys_pkey_mprotect)
__SYSCALL(__NR_pkey_alloc, sys_pkey_alloc)
#define __NR_pkey_free 290
__SYSCALL(__NR_pkey_free, sys_pkey_free)
+#define __NR_statx 291
+__SYSCALL(__NR_statx, sys_statx)

#undef __NR_syscalls
-#define __NR_syscalls 291
+#define __NR_syscalls 292

/*
* All syscalls below here should go away really,
--
2.9.3

2017-03-15 22:28:13

by James Hogan

Subject: Re: [PATCH v2] generic syscalls: Wire up statx syscall

On 13 March 2017 at 14:45, Stafford Horne <[email protected]> wrote:
> The new syscall statx is implemented as generic code, so enable it
> for architectures like openrisc which use the generic syscall table.
>
> Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> Cc: Thomas Gleixner <[email protected]>
> Cc: Al Viro <[email protected]>
> Cc: David Howells <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: [email protected]
> Signed-off-by: Stafford Horne <[email protected]>
> ---
> Change in v2:
> - Add a few more Cc's to get attention of the right people
> - Add a fixes tag for better audit
>
> include/uapi/asm-generic/unistd.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index 9b1462e..a076cf1 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -730,9 +730,11 @@ __SYSCALL(__NR_pkey_mprotect, sys_pkey_mprotect)
> __SYSCALL(__NR_pkey_alloc, sys_pkey_alloc)
> #define __NR_pkey_free 290
> __SYSCALL(__NR_pkey_free, sys_pkey_free)
> +#define __NR_statx 291
> +__SYSCALL(__NR_statx, sys_statx)
>
> #undef __NR_syscalls
> -#define __NR_syscalls 291
> +#define __NR_syscalls 292

Out of interest, anybody know OTOH which other stat syscalls statx
supersedes (such that they could at some point be disabled by default
in asm-generic for new arches, and implemented in userspace)?

Cheers
--
James Hogan

2017-03-16 09:48:41

by Arnd Bergmann

Subject: Re: [PATCH v2] generic syscalls: Wire up statx syscall

On Wed, Mar 15, 2017 at 11:26 PM, James Hogan <[email protected]> wrote:
> On 13 March 2017 at 14:45, Stafford Horne <[email protected]> wrote:

>> #undef __NR_syscalls
>> -#define __NR_syscalls 291
>> +#define __NR_syscalls 292
>
> Out of interest, anybody know OTOH which other stat syscalls statx
> supersedes (such that they could at some point be disabled by default
> in asm-generic for new arches, and implemented in userspace)?

It should replace the entire stat family {old,new,}{f,}stat{at,}{64,}, but not
the {f,}statfs{64,} family, which will eventually get another replacement.

Arnd

2017-03-20 12:33:17

by Will Deacon

Subject: Re: [PATCH v2] generic syscalls: Wire up statx syscall

On Mon, Mar 13, 2017 at 11:45:21PM +0900, Stafford Horne wrote:
> The new syscall statx is implemented as generic code, so enable it
> for architectures like openrisc which use the generic syscall table.
>
> Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> Cc: Thomas Gleixner <[email protected]>
> Cc: Al Viro <[email protected]>
> Cc: David Howells <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: [email protected]
> Signed-off-by: Stafford Horne <[email protected]>
> ---
> Change in v2:
> - Add a few more Cc's to get attention of the right people
> - Add a fixes tag for better audit
>
> include/uapi/asm-generic/unistd.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

As suggested by Arnd, I'll pick this up via arm64 for 4.11. I was on holiday
last week, so sorry for the delay.

Thanks,

Will

2017-03-20 14:12:41

by Stafford Horne

Subject: Re: [PATCH v2] generic syscalls: Wire up statx syscall

On Mon, Mar 20, 2017 at 12:33:20PM +0000, Will Deacon wrote:
> On Mon, Mar 13, 2017 at 11:45:21PM +0900, Stafford Horne wrote:
> > The new syscall statx is implemented as generic code, so enable it
> > for architectures like openrisc which use the generic syscall table.
> >
> > Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> > Cc: Thomas Gleixner <[email protected]>
> > Cc: Al Viro <[email protected]>
> > Cc: David Howells <[email protected]>
> > Cc: Catalin Marinas <[email protected]>
> > Cc: Will Deacon <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Stafford Horne <[email protected]>
> > ---
> > Change in v2:
> > - Add a few more Cc's to get attention of the right people
> > - Add a fixes tag for better audit
> >
> > include/uapi/asm-generic/unistd.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> As suggested by Arnd, I'll pick this up via arm64 for 4.11. I was on holiday
> last week, so sorry for the delay.

Thanks, I talked to Masami as well, and he told me that might be the
case.

-Stafford

> Thanks,
>
> Will