2017-03-27 10:01:20

by Tobias Regnery

[permalink] [raw]

Subject: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER

---

With CONFIG_RESET_CONTROLLER=n we get the following link error in the
sunxi-ng clk driver:

drivers/built-in.o: In function `sunxi_ccu_probe':
mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'

Fix this by adding the appropriate select statement.

Signed-off-by: Tobias Regnery <[email protected]>
---
drivers/clk/sunxi-ng/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 213cf64e4fab..8af8f4be8e3b 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -1,6 +1,7 @@
config SUNXI_CCU
bool "Clock support for Allwinner SoCs"
depends on ARCH_SUNXI || COMPILE_TEST
+ select RESET_CONTROLLER
default ARCH_SUNXI

if SUNXI_CCU
--
2.11.0

2017-03-27 11:43:52

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER

---

On Mon, Mar 27, 2017 at 11:57:53AM +0200, Tobias Regnery wrote:
> With CONFIG_RESET_CONTROLLER=n we get the following link error in the
> sunxi-ng clk driver:
>
> drivers/built-in.o: In function `sunxi_ccu_probe':
> mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
> mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'
>
> Fix this by adding the appropriate select statement.
>
> Signed-off-by: Tobias Regnery <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

---

Attachments:

(No filename) (671.00 B)
signature.asc (801.00 B)
Download all attachments