2017-03-30 16:54:27

by Ralph Sennhauser

Subject: [PATCH] ARM: dts: armada-385-linksys: disk-activity trigger for all

Commit a4ee7e18d808 ("ARM: dts: armada: Add default trigger for sata
led") adds the default trigger to individual boards, move it to
armada-385-linksys.dtsi which effectively enables the definition for
the WRT1900ACS (Shelby) as well as for future boards.

Signed-off-by: Ralph Sennhauser <[email protected]>
---
arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 -
arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 -
arch/arm/boot/dts/armada-385-linksys.dtsi | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index a1b6e68..f3cee91 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,7 +109,6 @@

sata {
label = "caiman:white:sata";
- linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index a1a75af..1110718 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,7 +109,6 @@

sata {
label = "cobra:white:sata";
- linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index aa0d225..2306c45 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -320,6 +320,7 @@
sata {
gpios = <&gpio1 22 GPIO_ACTIVE_LOW>;
default-state = "off";
+ linux,default-trigger = "disk-activity";
};
};

--
2.10.2

2017-03-31 15:36:11

by Andrew Lunn

Subject: Re: [PATCH] ARM: dts: armada-385-linksys: disk-activity trigger for all

On Thu, Mar 30, 2017 at 06:54:04PM +0200, Ralph Sennhauser wrote:
> Commit a4ee7e18d808 ("ARM: dts: armada: Add default trigger for sata
> led") adds the default trigger to individual boards, move it to
> armada-385-linksys.dtsi which effectively enables the definition for
> the WRT1900ACS (Shelby) as well as for future boards.
>
> Signed-off-by: Ralph Sennhauser <[email protected]>

Centralising this makes sense.

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2017-04-05 15:27:23

by Gregory CLEMENT

Subject: Re: [PATCH] ARM: dts: armada-385-linksys: disk-activity trigger for all

Hi Ralph,

On ven., mars 31 2017, Andrew Lunn <[email protected]> wrote:

> On Thu, Mar 30, 2017 at 06:54:04PM +0200, Ralph Sennhauser wrote:
>> Commit a4ee7e18d808 ("ARM: dts: armada: Add default trigger for sata
>> led") adds the default trigger to individual boards, move it to
>> armada-385-linksys.dtsi which effectively enables the definition for
>> the WRT1900ACS (Shelby) as well as for future boards.
>>
>> Signed-off-by: Ralph Sennhauser <[email protected]>
>
> Centralising this makes sense.
>
> Reviewed-by: Andrew Lunn <[email protected]>

Applied on mvebu/dt

Thanks,

Gregory


--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com