2017-04-01 14:18:44

by Simran Singhal

Subject: [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)

Signed-off-by: simran singhal <[email protected]>
---
drivers/iio/pressure/zpa2326.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index c720c3a..e58a0ad 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -751,7 +751,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
*/
static irqreturn_t zpa2326_handle_irq(int irq, void *data)
{
- struct iio_dev *indio_dev = (struct iio_dev *)data;
+ struct iio_dev *indio_dev = data;

if (iio_buffer_enabled(indio_dev)) {
/* Timestamping needed for buffered sampling only. */
@@ -790,7 +790,7 @@ static irqreturn_t zpa2326_handle_irq(int irq, void *data)
*/
static irqreturn_t zpa2326_handle_threaded_irq(int irq, void *data)
{
- struct iio_dev *indio_dev = (struct iio_dev *)data;
+ struct iio_dev *indio_dev = data;
struct zpa2326_private *priv = iio_priv(indio_dev);
unsigned int val;
bool cont;
--
2.7.4

2017-04-02 08:52:53

by Jonathan Cameron

Subject: Re: [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

On 01/04/17 15:18, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal <[email protected]>
Applied and pushed out as testing as normal.

Thanks for these. Good to clean them up. It's one of my pet
hates, but still the sometimes get through ;)

Jonathan
> ---
> drivers/iio/pressure/zpa2326.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
> index c720c3a..e58a0ad 100644
> --- a/drivers/iio/pressure/zpa2326.c
> +++ b/drivers/iio/pressure/zpa2326.c
> @@ -751,7 +751,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
> */
> static irqreturn_t zpa2326_handle_irq(int irq, void *data)
> {
> - struct iio_dev *indio_dev = (struct iio_dev *)data;
> + struct iio_dev *indio_dev = data;
>
> if (iio_buffer_enabled(indio_dev)) {
> /* Timestamping needed for buffered sampling only. */
> @@ -790,7 +790,7 @@ static irqreturn_t zpa2326_handle_irq(int irq, void *data)
> */
> static irqreturn_t zpa2326_handle_threaded_irq(int irq, void *data)
> {
> - struct iio_dev *indio_dev = (struct iio_dev *)data;
> + struct iio_dev *indio_dev = data;
> struct zpa2326_private *priv = iio_priv(indio_dev);
> unsigned int val;
> bool cont;
>