2017-03-21 10:16:41

by Peter De Schrijver

Subject: [PATCH] clk: aggregate return codes of notify chains

In case there are multiple notify chains for the same clocks (because they
were registered by different users), we need to propagate potential failure
of any single one of them to the caller. Otherwise we eg risk violating the
V/f curve when a notifier is used for DVFS.

Signed-off-by: Peter De Schrijver <[email protected]>
---
drivers/clk/clk.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 67201f6..f5f2bcd 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -966,6 +966,8 @@ static int __clk_notify(struct clk_core *core, unsigned long msg,
cnd.clk = cn->clk;
ret = srcu_notifier_call_chain(&cn->notifier_head, msg,
&cnd);
+ if (ret & NOTIFY_STOP_MASK)
+ return ret;
}
}

--
1.9.1

2017-04-07 19:47:12

by Stephen Boyd

Subject: Re: [PATCH] clk: aggregate return codes of notify chains

On 03/21, Peter De Schrijver wrote:
> In case there are multiple notify chains for the same clocks (because they
> were registered by different users), we need to propagate potential failure
> of any single one of them to the caller. Otherwise we eg risk violating the
> V/f curve when a notifier is used for DVFS.
>
> Signed-off-by: Peter De Schrijver <[email protected]>
> ---

Applied to clk-next. Let's see if anything blows up.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project