2017-04-10 12:19:06

by Tobias Regnery

[permalink] [raw]
Subject: [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver

The ccu-sun9i-a80 driver uses the ccu_mult_ops struct, but unlike the other
users it doesen't select the corresponding Kconfig symbol under which the
struct is compiled in.

This results in the following link error with CONFIG_SUN9I_A80_CCU=y and
CONFIG_SUNXI_CCU_MULT=n:

drivers/built-in.o:(.data+0x2d638): undefined reference to 'ccu_mult_ops'

Fix this by explicitly selecting CONFIG_SUNXI_CCU_MULT like the other
users of the struct.

Signed-off-by: Tobias Regnery <[email protected]>
---
drivers/clk/sunxi-ng/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index fbd3f8cd5c22..64088e599404 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -143,6 +143,7 @@ config SUN8I_V3S_CCU
config SUN9I_A80_CCU
bool "Support for the Allwinner A80 CCU"
select SUNXI_CCU_DIV
+ select SUNXI_CCU_MULT
select SUNXI_CCU_GATE
select SUNXI_CCU_NKMP
select SUNXI_CCU_NM
--
2.11.0


2017-04-13 09:11:15

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver

On Mon, Apr 10, 2017 at 02:15:44PM +0200, Tobias Regnery wrote:
> The ccu-sun9i-a80 driver uses the ccu_mult_ops struct, but unlike the other
> users it doesen't select the corresponding Kconfig symbol under which the
> struct is compiled in.
>
> This results in the following link error with CONFIG_SUN9I_A80_CCU=y and
> CONFIG_SUNXI_CCU_MULT=n:
>
> drivers/built-in.o:(.data+0x2d638): undefined reference to 'ccu_mult_ops'
>
> Fix this by explicitly selecting CONFIG_SUNXI_CCU_MULT like the other
> users of the struct.
>
> Signed-off-by: Tobias Regnery <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


Attachments:
(No filename) (711.00 B)
signature.asc (801.00 B)
Download all attachments