No need to get into the submenu to disable all AMBA-related config entries
Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/amba/Kconfig | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig
index 294ba6f..3f8fcb8 100644
--- a/drivers/amba/Kconfig
+++ b/drivers/amba/Kconfig
@@ -1,14 +1,8 @@
-config ARM_AMBA
- bool
-
-if ARM_AMBA
-
-config TEGRA_AHB
- bool
+menuconfig TEGRA_AHB
+ bool "NVIDIA Tegra AHB"
+ depends on ARCH_TEGRA
default y if ARCH_TEGRA
help
Adds AHB configuration functionality for NVIDIA Tegra SoCs,
which controls AHB bus master arbitration and some performance
parameters (priority, prefetch size).
-
-endif
--
2.9.3
On Fri, Apr 14, 2017 at 01:39:32PM +0200, Vincent Legoll wrote:
> No need to get into the submenu to disable all AMBA-related config entries
>
> Signed-off-by: Vincent Legoll <[email protected]>
This patch is completely incorrect - it removes the ARM_AMBA symbol which
is used elsewhere, thereby breaking every AMBA device in the kernel.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Hello,
On Fri, Apr 14, 2017 at 1:47 PM, Russell King - ARM Linux
<[email protected]> wrote:
> This patch is completely incorrect - it removes the ARM_AMBA symbol which
> is used elsewhere, thereby breaking every AMBA device in the kernel.
Yep you're right, I was going after something else (BCMA) and got confused
by its naming: "Broadcom specific AMBA".
Please disregard that patch, and sorry for the noise.
--
Vincent Legoll
Hi Vincent,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc6 next-20170413]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vincent-Legoll/Make-AMBA-a-menuconfig-to-ease-disabling-it-all/20170414-194337
config: arm-integrator_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All warnings (new ones prefixed by >>):
warning: (ARCH_INTEGRATOR_AP) selects SERIAL_AMBA_PL010 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA)
warning: (ARCH_INTEGRATOR_CP) selects SERIAL_AMBA_PL011 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA)
warning: (ARCH_REALVIEW && ARCH_SOCFPGA && INTEGRATOR_IMPD1) selects GPIO_PL061 which has unmet direct dependencies (GPIOLIB && HAS_IOMEM && ARM_AMBA)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Vincent,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.11-rc6 next-20170413]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vincent-Legoll/Make-AMBA-a-menuconfig-to-ease-disabling-it-all/20170414-194337
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All error/warnings (new ones prefixed by >>):
warning: (ARCH_HIGHBANK) selects PL320_MBOX which has unmet direct dependencies (MAILBOX && ARM_AMBA)
warning: (MACH_NOMADIK_8815NHK && MACH_MOP500) selects I2C_NOMADIK which has unmet direct dependencies (I2C && HAS_IOMEM && ARM_AMBA)
drivers/built-in.o: In function `pl061_gpio_init':
>> sunxi_sid.c:(.init.text+0x7334): undefined reference to `amba_driver_register'
drivers/built-in.o: In function `nmk_i2c_init':
sunxi_sid.c:(.init.text+0x5a32c): undefined reference to `amba_driver_register'
drivers/built-in.o: In function `ipc_init':
sunxi_sid.c:(.init.text+0x68454): undefined reference to `amba_driver_register'
drivers/built-in.o: In function `nmk_i2c_exit':
>> sunxi_sid.c:(.exit.text+0x1ef4): undefined reference to `amba_driver_unregister'
arch/arm/mach-highbank/built-in.o: In function `highbank_init':
>> pm.c:(.init.text+0x74): undefined reference to `amba_bustype'
pm.c:(.init.text+0x78): undefined reference to `amba_bustype'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hello,
this is more what I wanted to achieve, an easily disableable BCMA menuconfig.
This is working as intended on x86_64 defconfig, whereas it is harder to disable
for ARCH=arm because of "select"s. But that's less of an issue, as those arch's
defconfigs may very well want the feature enbled, and that would make sense.
Any input appreciated.
Thanks
No need to get into the submenu to disable all BCMA-related config entries
Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/bcma/Kconfig | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index b5c48a8..54f81c5 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -3,11 +3,8 @@ config BCMA_POSSIBLE
depends on HAS_IOMEM && HAS_DMA
default y
-menu "Broadcom specific AMBA"
- depends on BCMA_POSSIBLE
-
-config BCMA
- tristate "BCMA support"
+menuconfig BCMA
+ tristate "Broadcom specific AMBA"
depends on BCMA_POSSIBLE
help
Bus driver for Broadcom specific Advanced Microcontroller Bus
@@ -117,5 +114,3 @@ config BCMA_DEBUG
This turns on additional debugging messages.
If unsure, say N
-
-endmenu
--
2.9.3
Argh,
looks like the "--in-reply-to" did not hook it up properly...
This was intended as a reply to:
http://lkml.iu.edu/hypermail/linux/kernel/1704.1/04654.html
Re: [PATCH] Make AMBA a menuconfig to ease disabling it all
from (Fri Apr 14 2017 - 08:33:57 EST)
Sorry
--
Vincent Legoll
Vincent Legoll <[email protected]> wrote:
> No need to get into the submenu to disable all BCMA-related config entries.
>
> Signed-off-by: Vincent Legoll <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
9ca766b3641f bcma: make BCMA a menuconfig to ease disabling it all
--
https://patchwork.kernel.org/patch/9683685/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches