2017-04-25 15:40:53

by Shuah Khan

Subject: [PATCH v2] selftests: splice: override clean in lib.mk to fix warnings

Add override with EXTRA_CLEAN for lib.mk clean to fix the following
warnings from clean target run.

Makefile:8: warning: overriding recipe for target 'clean'
../lib.mk:55: warning: ignoring old recipe for target 'clean'

Signed-off-by: Shuah Khan <[email protected]>
---
Changes since v1:
- simplified to use EXTRA_CLEAN based on Michael Ellerman's comments.

tools/testing/selftests/splice/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile
index 559512c..9fc78e5 100644
--- a/tools/testing/selftests/splice/Makefile
+++ b/tools/testing/selftests/splice/Makefile
@@ -4,5 +4,4 @@ all: $(TEST_PROGS) $(EXTRA)

include ../lib.mk

-clean:
- rm -fr $(EXTRA)
+EXTRA_CLEAN := $(EXTRA)
--
2.9.3

2017-04-25 15:40:44

by Shuah Khan

Subject: [PATCH v2] selftests: sync: override clean in lib.mk to fix warnings

Add override with EXTRA_CLEAN for lib.mk clean to fix the following
warnings from clean target run.

Makefile:24: warning: overriding recipe for target 'clean'
../lib.mk:55: warning: ignoring old recipe for target 'clean'

Signed-off-by: Shuah Khan <[email protected]>
---
Changes since v1:
- simplified to use EXTRA_CLEAN based on Michael Ellerman's comments.

tools/testing/selftests/sync/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/sync/Makefile b/tools/testing/selftests/sync/Makefile
index 87ac400..4981c6b 100644
--- a/tools/testing/selftests/sync/Makefile
+++ b/tools/testing/selftests/sync/Makefile
@@ -20,5 +20,4 @@ TESTS += sync_stress_merge.o

sync_test: $(OBJS) $(TESTS)

-clean:
- $(RM) sync_test $(OBJS) $(TESTS)
+EXTRA_CLEAN := sync_test $(OBJS) $(TESTS)
--
2.9.3

2017-04-25 15:41:10

by Shuah Khan

Subject: [PATCH v2] selftests: x86: override clean in lib.mk to fix warnings

Add override with EXTRA_CLEAN for lib.mk clean to fix the following
warnings from clean target run.

Makefile:44: warning: overriding recipe for target 'clean'
../lib.mk:55: warning: ignoring old recipe for target 'clean'

Signed-off-by: Shuah Khan <[email protected]>
---
Changes since v1:
- simplified to use EXTRA_CLEAN based on Michael Ellerman's comments.

tools/testing/selftests/x86/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 38e0a9c..97f187e 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -40,8 +40,7 @@ all_32: $(BINARIES_32)

all_64: $(BINARIES_64)

-clean:
- $(RM) $(BINARIES_32) $(BINARIES_64)
+EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64)

$(BINARIES_32): $(OUTPUT)/%_32: %.c
$(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm
--
2.9.3