2017-04-25 16:13:48

by Wei Yongjun

Subject: [PATCH -next] auxdisplay: Convert list_for_each to entry variant

From: Wei Yongjun <[email protected]>

convert list_for_each() to list_for_each_entry() where
applicable.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/auxdisplay/panel.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index e0c014c..7a8b8fb 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1345,14 +1345,11 @@ static inline void input_state_falling(struct logical_input *input)

static void panel_process_inputs(void)
{
- struct list_head *item;
struct logical_input *input;

keypressed = 0;
inputs_stable = 1;
- list_for_each(item, &logical_inputs) {
- input = list_entry(item, struct logical_input, list);
-
+ list_for_each_entry(input, &logical_inputs, list) {
switch (input->state) {
case INPUT_ST_LOW:
if ((phys_curr & input->mask) != input->value)

2017-04-25 18:15:21

by Andy Shevchenko

Subject: Re: [PATCH -next] auxdisplay: Convert list_for_each to entry variant

On Tue, 2017-04-25 at 16:13 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> convert list_for_each() to list_for_each_entry() where
> applicable.
>

Here it's safe to do.
FWIW: 
Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Wei Yongjun <[email protected]>
> ---
>  drivers/auxdisplay/panel.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
> index e0c014c..7a8b8fb 100644
> --- a/drivers/auxdisplay/panel.c
> +++ b/drivers/auxdisplay/panel.c
> @@ -1345,14 +1345,11 @@ static inline void input_state_falling(struct
> logical_input *input)
>  
>  static void panel_process_inputs(void)
>  {
> - struct list_head *item;
>   struct logical_input *input;
>  
>   keypressed = 0;
>   inputs_stable = 1;
> - list_for_each(item, &logical_inputs) {
> - input = list_entry(item, struct logical_input, list);
> -
> + list_for_each_entry(input, &logical_inputs, list) {
>   switch (input->state) {
>   case INPUT_ST_LOW:
>   if ((phys_curr & input->mask) != input-
> >value)
>

--
Andy Shevchenko <[email protected]>
Intel Finland Oy