2017-04-21 07:02:38

by Colin King

Subject: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

From: Colin Ian King <[email protected]>

trivial fix to spelling mistake in dev_err message

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/pci/dwc/pci-imx6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 102edcf1e261..129717ae5022 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev)
imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
"pciephy");
if (IS_ERR(imx6_pcie->pciephy_reset)) {
- dev_err(dev, "Failed to get PCIEPHY reset contol\n");
+ dev_err(dev, "Failed to get PCIEPHY reset control\n");
return PTR_ERR(imx6_pcie->pciephy_reset);
}

imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
if (IS_ERR(imx6_pcie->apps_reset)) {
- dev_err(dev, "Failed to get PCIE APPS reset contol\n");
+ dev_err(dev, "Failed to get PCIE APPS reset control\n");
return PTR_ERR(imx6_pcie->apps_reset);
}
break;
--
2.11.0

2017-04-25 06:10:07

by Richard Zhu

Subject: RE: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

> -----Original Message-----
> From: Colin King [mailto:[email protected]]
> Sent: Friday, April 21, 2017 3:03 PM
> To: Richard Zhu <[email protected]>; Lucas Stach
> <[email protected]>; Bjorn Helgaas <[email protected]>; linux-
> [email protected]; [email protected]
> Cc: [email protected]
> Subject: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
>
> From: Colin Ian King <[email protected]>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Richard Zhu <[email protected]>

Best Regards
hongxing zhu
Email: [email protected]

> ---
> drivers/pci/dwc/pci-imx6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index
> 102edcf1e261..129717ae5022 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
> imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> - dev_err(dev, "Failed to get PCIEPHY reset contol\n");
> + dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> imx6_pcie->apps_reset = devm_reset_control_get(dev,
> "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> - dev_err(dev, "Failed to get PCIE APPS reset
> contol\n");
> + dev_err(dev, "Failed to get PCIE APPS reset
> control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> }
> break;
> --
> 2.11.0

2017-04-25 19:04:44

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied with Richard's ack to pci/host-imx6 for v4.12, thanks.

FWIW, there are about 25 other occurrences of "contol" in other parts
of the tree.

> ---
> drivers/pci/dwc/pci-imx6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
> index 102edcf1e261..129717ae5022 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> - dev_err(dev, "Failed to get PCIEPHY reset contol\n");
> + dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> - dev_err(dev, "Failed to get PCIE APPS reset contol\n");
> + dev_err(dev, "Failed to get PCIE APPS reset control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> }
> break;
> --
> 2.11.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2017-04-25 19:22:18

by Joe Perches

Subject: Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

On Tue, 2017-04-25 at 14:04 -0500, Bjorn Helgaas wrote:
> On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > trivial fix to spelling mistake in dev_err message
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Applied with Richard's ack to pci/host-imx6 for v4.12, thanks.
>
> FWIW, there are about 25 other occurrences of "contol" in other parts
> of the tree.

Colin seems to focus on the logging format strings and
not code comments.

Other than these 2, there are 28 other instances in -next.
All of them are not output anywhere, these are just source
code comments.

$ git grep -w -i -E "contoller|contol" | wc -l
30