2017-06-02 11:30:06

by Tobias Klauser

[permalink] [raw]
Subject: [PATCH] pinctrl: sunxi: constify irq_domain_ops

struct irq_domain_ops is not modified, so it can be made const.

Suggested-by: Marc Zyngier <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 58774acfc814..0dfd7fa66c48 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -979,7 +979,7 @@ static int sunxi_pinctrl_irq_of_xlate(struct irq_domain *d,
return 0;
}

-static struct irq_domain_ops sunxi_pinctrl_irq_domain_ops = {
+static const struct irq_domain_ops sunxi_pinctrl_irq_domain_ops = {
.xlate = sunxi_pinctrl_irq_of_xlate,
};

--
2.13.0



2017-06-02 12:08:21

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: sunxi: constify irq_domain_ops

On Fri, Jun 02, 2017 at 01:29:58PM +0200, Tobias Klauser wrote:
> struct irq_domain_ops is not modified, so it can be made const.
>
> Suggested-by: Marc Zyngier <[email protected]>
> Signed-off-by: Tobias Klauser <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (406.00 B)
 signature.asc (801.00 B)
 Download all attachments

2017-06-09 08:59:39

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: sunxi: constify irq_domain_ops

On Fri, Jun 2, 2017 at 1:29 PM, Tobias Klauser <[email protected]> wrote:

> struct irq_domain_ops is not modified, so it can be made const.
>
> Suggested-by: Marc Zyngier <[email protected]>
> Signed-off-by: Tobias Klauser <[email protected]>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij