2017-06-03 14:08:33

by Greg Kroah-Hartman

Subject: Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

On Wed, May 31, 2017 at 01:58:43PM +0300, [email protected] wrote:
> From: Laurentiu Tudor <[email protected]>
>
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
>
> Found with checkpatch.pl who was issuing this
> message:
> "Macro argument 'id' may be better as '(id)'
> to avoid precedence issues"

Why are you line-wrapping at such a small number? Please use 72 columns
like git asks you to...

thanks,

greg k-h

2017-06-06 12:03:59

by Laurentiu Tudor

Subject: RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

Hi Greg,

> -----Original Message-----
> From: Greg KH [mailto:[email protected]]
> Sent: Saturday, June 03, 2017 11:41 AM
>
> On Wed, May 31, 2017 at 01:58:43PM +0300, [email protected] wrote:
> > From: Laurentiu Tudor <[email protected]>
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> > "Macro argument 'id' may be better as '(id)'
> > to avoid precedence issues"
>
> Why are you line-wrapping at such a small number? Please use 72 columns like
> git asks you to...

I'll rewrap the commit message in the next spin.

---
Thanks & Best Regards, Laurentiu