2017-06-12 12:04:49

by Alexander Wuerstlein

Subject: [PATCH] iio hid-sensor-trigger: add Kconfig depends on IIO_BUFFER

Building a kernel with my configuration failed with:
> drivers/built-in.o: In function `hid_sensor_setup_batch_mode': staging/drivers/iio/common/hid-sensors/hid-sensor-trigger.c:104: undefined reference to `iio_buffer_set_attrs'
which is fixed by this patch.

Signed-off-by: Alexander Wuerstlein <[email protected]>
---
drivers/iio/common/hid-sensors/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/common/hid-sensors/Kconfig b/drivers/iio/common/hid-sensors/Kconfig
index 39188b72cd3b..80105378b0ba 100644
--- a/drivers/iio/common/hid-sensors/Kconfig
+++ b/drivers/iio/common/hid-sensors/Kconfig
@@ -16,7 +16,7 @@ config HID_SENSOR_IIO_COMMON

config HID_SENSOR_IIO_TRIGGER
tristate "Common module (trigger) for all HID Sensor IIO drivers"
- depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON
+ depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && IIO_BUFFER
select IIO_TRIGGER
help
Say yes here to build trigger support for HID sensors.
--
2.11.0

2017-06-13 20:13:28

by Jonathan Cameron

Subject: Re: [PATCH] iio hid-sensor-trigger: add Kconfig depends on IIO_BUFFER

On Mon, 12 Jun 2017 13:56:05 +0200
Alexander Wuerstlein <[email protected]> wrote:

> Building a kernel with my configuration failed with:
> > drivers/built-in.o: In function `hid_sensor_setup_batch_mode': staging/drivers/iio/common/hid-sensors/hid-sensor-trigger.c:104: undefined reference to `iio_buffer_set_attrs'
> which is fixed by this patch.
>
> Signed-off-by: Alexander Wuerstlein <[email protected]>
Added a fixes tag as the issue was only introduced very recently.

Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
> drivers/iio/common/hid-sensors/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/hid-sensors/Kconfig b/drivers/iio/common/hid-sensors/Kconfig
> index 39188b72cd3b..80105378b0ba 100644
> --- a/drivers/iio/common/hid-sensors/Kconfig
> +++ b/drivers/iio/common/hid-sensors/Kconfig
> @@ -16,7 +16,7 @@ config HID_SENSOR_IIO_COMMON
>
> config HID_SENSOR_IIO_TRIGGER
> tristate "Common module (trigger) for all HID Sensor IIO drivers"
> - depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON
> + depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && IIO_BUFFER
> select IIO_TRIGGER
> help
> Say yes here to build trigger support for HID sensors.