2017-06-13 13:29:13

by Colin King

Subject: [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const

From: Colin Ian King <[email protected]>

The array tcmu_attrib_attrs does not need to be in global scope, so make
it static.

Cleans up sparse warning:
"symbol 'tcmu_attrib_attrs' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/target/target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index afc1fd6bacaf..04fb3f720895 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1672,7 +1672,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
}
CONFIGFS_ATTR(tcmu_, emulate_write_cache);

-struct configfs_attribute *tcmu_attrib_attrs[] = {
+static struct configfs_attribute *tcmu_attrib_attrs[] = {
&tcmu_attr_cmd_time_out,
&tcmu_attr_dev_path,
&tcmu_attr_dev_size,
--
2.11.0

2017-06-25 20:55:53

by Nicholas A. Bellinger

Subject: Re: [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const

On Tue, 2017-06-13 at 14:29 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The array tcmu_attrib_attrs does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'tcmu_attrib_attrs' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index afc1fd6bacaf..04fb3f720895 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1672,7 +1672,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
> }
> CONFIGFS_ATTR(tcmu_, emulate_write_cache);
>
> -struct configfs_attribute *tcmu_attrib_attrs[] = {
> +static struct configfs_attribute *tcmu_attrib_attrs[] = {
> &tcmu_attr_cmd_time_out,
> &tcmu_attr_dev_path,
> &tcmu_attr_dev_size,

Applied.

Thanks Colin.