2017-06-02 20:10:04

by Eric Anholt

[permalink] [raw]
Subject: Re: [PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

Jose Abreu <[email protected]> writes:

> Now that we have a callback to check if crtc and encoder supports a
> given mode we can use it in vc4 so that we restrict the number of
> probbed modes to the ones we can actually display.

"probed"

>
> Also, remove the mode_fixup() calls as these are no longer needed
> because mode_valid() will be called before.
>
> NOTE: Not even compiled tested

Compile-tested and Reviewed-by: Eric Anholt <[email protected]>


Attachments:
signature.asc (832.00 B)

2017-06-20 08:48:50

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

On Fri, Jun 02, 2017 at 01:10:00PM -0700, Eric Anholt wrote:
> Jose Abreu <[email protected]> writes:
>
> > Now that we have a callback to check if crtc and encoder supports a
> > given mode we can use it in vc4 so that we restrict the number of
> > probbed modes to the ones we can actually display.
>
> "probed"
>
> >
> > Also, remove the mode_fixup() calls as these are no longer needed
> > because mode_valid() will be called before.
> >
> > NOTE: Not even compiled tested
>
> Compile-tested and Reviewed-by: Eric Anholt <[email protected]>

Pushed to drm-misc-next, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch