2017-06-02 11:36:14

by Roosen Henri

[permalink] [raw]
Subject: [PATCH] rpmsg: cleanup incorrect function in dev_err message

Trivial cleanup for incorrect function in dev_err message

Signed-off-by: Henri Roosen <[email protected]>
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index 0ca2ccc..0b5d0d3 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -390,7 +390,7 @@ static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev,

ret = device_add(dev);
if (ret) {
- dev_err(dev, "device_register failed: %d\n", ret);
+ dev_err(dev, "device_add failed: %d\n", ret);
put_device(dev);
}

@@ -505,7 +505,7 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev)

ret = device_add(dev);
if (ret) {
- dev_err(&rpdev->dev, "device_register failed: %d\n", ret);
+ dev_err(&rpdev->dev, "device_add failed: %d\n", ret);
put_device(dev);
}

--
2.1.4


2017-06-25 21:36:34

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] rpmsg: cleanup incorrect function in dev_err message

On Fri 02 Jun 04:36 PDT 2017, Henri Roosen wrote:

> Trivial cleanup for incorrect function in dev_err message
>
> Signed-off-by: Henri Roosen <[email protected]>

Applied, thanks

> ---
> drivers/rpmsg/rpmsg_char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index 0ca2ccc..0b5d0d3 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -390,7 +390,7 @@ static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev,
>
> ret = device_add(dev);
> if (ret) {
> - dev_err(dev, "device_register failed: %d\n", ret);
> + dev_err(dev, "device_add failed: %d\n", ret);
> put_device(dev);
> }
>
> @@ -505,7 +505,7 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev)
>
> ret = device_add(dev);
> if (ret) {
> - dev_err(&rpdev->dev, "device_register failed: %d\n", ret);
> + dev_err(&rpdev->dev, "device_add failed: %d\n", ret);
> put_device(dev);
> }
>
> --
> 2.1.4
>