2017-06-26 15:48:38

by Fengguang Wu

Subject: [PATCH] xfs: fix semicolon.cocci warnings

fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
CC: Brian Foster <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -2089,7 +2089,7 @@ xlog_print_trans(
xfs_warn(mp, " type = 0x%x", vec->i_type);
xfs_warn(mp, " len = %d", vec->i_len);
xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
- xfs_hex_dump(vec->i_addr, dumplen);;
+ xfs_hex_dump(vec->i_addr, dumplen);

vec++;
}

2017-06-26 15:52:46

by Brian Foster

Subject: Re: [PATCH] xfs: fix semicolon.cocci warnings

On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---

Reviewed-by: Brian Foster <[email protected]>

>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
> xfs_warn(mp, " type = 0x%x", vec->i_type);
> xfs_warn(mp, " len = %d", vec->i_len);
> xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
> - xfs_hex_dump(vec->i_addr, dumplen);;
> + xfs_hex_dump(vec->i_addr, dumplen);
>
> vec++;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2017-06-26 15:55:00

by Darrick J. Wong

Subject: Re: [PATCH] xfs: fix semicolon.cocci warnings

On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>

Looks good, will test...
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
> xfs_warn(mp, " type = 0x%x", vec->i_type);
> xfs_warn(mp, " len = %d", vec->i_len);
> xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
> - xfs_hex_dump(vec->i_addr, dumplen);;
> + xfs_hex_dump(vec->i_addr, dumplen);
>
> vec++;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html