2017-06-29 01:54:12

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the sound-asoc tree

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this function)
struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
^
sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/codecs/rt5670.c: At top level:
sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_sysclk = rt5670_set_codec_sysclk,
^
sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for 'soc_codec_dev_rt5670.set_sysclk')
cc1: some warnings being treated as errors

Caused by commit

6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")

I have used the sound-asoc tree from next-20170628 for today.

--
Cheers,
Stephen Rothwell


2017-06-29 02:01:37

by Bard Liao

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the sound-asoc tree

> -----Original Message-----
> From: Stephen Rothwell [mailto:[email protected]]
> Sent: Thursday, June 29, 2017 9:54 AM
> To: Mark Brown; Liam Girdwood
> Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> Subject: linux-next: build failure after merge of the sound-asoc tree
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> function)
> struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> ^
> sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> reported only once for each function it appears in
> sound/soc/codecs/rt5670.c: At top level:
> sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> pointer type [-Werror=incompatible-pointer-types]
> .set_sysclk = rt5670_set_codec_sysclk,
> ^
> sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> 'soc_codec_dev_rt5670.set_sysclk')
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
>
> I have used the sound-asoc tree from next-20170628 for today.

Sorry about that. I just sent a patch to fix it. Please check the attached.

>
> --
> Cheers,
> Stephen Rothwell
>
> ------Please consider the environment before printing this e-mail.


Attachments:
0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch (0.99 kB)
0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch

2017-06-30 01:51:39

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the sound-asoc tree

Hi Bard,

On Thu, 29 Jun 2017 02:01:16 +0000 Bard Liao <[email protected]> wrote:
>
> > -----Original Message-----
> > From: Stephen Rothwell [mailto:[email protected]]
> > Sent: Thursday, June 29, 2017 9:54 AM
> > To: Mark Brown; Liam Girdwood
> > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > Subject: linux-next: build failure after merge of the sound-asoc tree
> >
> > Hi all,
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> > function)
> > struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> > ^
> > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > reported only once for each function it appears in
> > sound/soc/codecs/rt5670.c: At top level:
> > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > pointer type [-Werror=incompatible-pointer-types]
> > .set_sysclk = rt5670_set_codec_sysclk,
> > ^
> > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > 'soc_codec_dev_rt5670.set_sysclk')
> > cc1: some warnings being treated as errors
> >
> > Caused by commit
> >
> > 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> >
> > I have used the sound-asoc tree from next-20170628 for today.
>
> Sorry about that. I just sent a patch to fix it. Please check the attached.

I have applied your patch (attached) for today.

Mark, Liam, please apply.

Tested-by: Stephen Rothwell <[email protected]>

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (1.73 kB)
0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch (1.00 kB)
Download all attachments

2017-07-03 03:21:06

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the sound-asoc tree

Hi all,

On Fri, 30 Jun 2017 11:51:35 +1000 Stephen Rothwell <[email protected]> wrote:
>
> On Thu, 29 Jun 2017 02:01:16 +0000 Bard Liao <[email protected]> wrote:
> >
> > > -----Original Message-----
> > > From: Stephen Rothwell [mailto:[email protected]]
> > > Sent: Thursday, June 29, 2017 9:54 AM
> > > To: Mark Brown; Liam Girdwood
> > > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > > Subject: linux-next: build failure after merge of the sound-asoc tree
> > >
> > > Hi all,
> > >
> > > After merging the sound-asoc tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> > > function)
> > > struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> > > ^
> > > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > > reported only once for each function it appears in
> > > sound/soc/codecs/rt5670.c: At top level:
> > > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > > pointer type [-Werror=incompatible-pointer-types]
> > > .set_sysclk = rt5670_set_codec_sysclk,
> > > ^
> > > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > > 'soc_codec_dev_rt5670.set_sysclk')
> > > cc1: some warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > > 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> > >
> > > I have used the sound-asoc tree from next-20170628 for today.
> >
> > Sorry about that. I just sent a patch to fix it. Please check the attached.
>
> I have applied your patch (attached) for today.
>
> Mark, Liam, please apply.
>
> Tested-by: Stephen Rothwell <[email protected]>

Ping?

--
Cheers,
Stephen Rothwell