2017-06-30 07:26:01

by Lee, Chun-Yi

[permalink] [raw]
Subject: [PATCH v3] acpi: handle the acpi hotplug schedule error

Kernel should decrements the reference count of acpi device
when the scheduling of acpi hotplug work failed, and evaluates
_OST to notify BIOS the failure.

v3:
More simplify the code. (Rafael J. Wysocki)

v2:
To simplify the code. (Andy Shevchenko)

Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Michal Hocko <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Signed-off-by: "Lee, Chun-Yi" <[email protected]>
---
drivers/acpi/bus.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 784bda6..9d4fea6 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
(driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
driver->ops.notify(adev, type);

- if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
+ if (!hotplug_event) {
+ acpi_bus_put_acpi_device(adev);
+ return;
+ }
+
+ if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
return;

acpi_bus_put_acpi_device(adev);
- return;

err:
acpi_evaluate_ost(handle, type, ost_code, NULL);
--
2.10.2