2017-06-30 22:37:50

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] ASoC: imx-ssi: add check on platform_get_irq return value

Check return value from call to platform_get_irq(),
so in case of failure print error message and propagate
the return value.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/fsl/imx-ssi.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index b95132e..0679061 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
}

ssi->irq = platform_get_irq(pdev, 0);
+ if (ssi->irq < 0) {
+ dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
+ return ssi->irq;
+ }

ssi->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(ssi->clk)) {
--
2.5.0


2017-07-01 04:51:51

by Nicolin Chen

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-ssi: add check on platform_get_irq return value

On Fri, Jun 30, 2017 at 05:17:35PM -0500, Gustavo A. R. Silva wrote:
> Check return value from call to platform_get_irq(),
> so in case of failure print error message and propagate
> the return value.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Nicolin Chen <[email protected]>

Thanks

> ---
> sound/soc/fsl/imx-ssi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
> index b95132e..0679061 100644
> --- a/sound/soc/fsl/imx-ssi.c
> +++ b/sound/soc/fsl/imx-ssi.c
> @@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
> }
>
> ssi->irq = platform_get_irq(pdev, 0);
> + if (ssi->irq < 0) {
> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
> + return ssi->irq;
> + }
>
> ssi->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(ssi->clk)) {
> --
> 2.5.0
>