2017-06-30 22:34:27

by Gustavo A. R. Silva

Subject: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()

platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/atmel/ac97c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 65e6948..9d2c9d9 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_dbg(&pdev->dev, "could not get irq\n");
- return -ENXIO;
+ dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
+ return irq;
}

pclk = clk_get(&pdev->dev, "ac97_clk");
--
2.5.0

2017-07-01 06:06:52

by Takashi Iwai

Subject: Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()

On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
>
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied, thanks.


Takashi