2017-06-30 11:00:19

by Colin King

Subject: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

From: Colin Ian King <[email protected]>

Trivial fix to spelling mistake in mlx5_core_dbg debug message

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
index 4d0db481f6c4..de2aed44ab85 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
@@ -101,7 +101,7 @@ int mlx5_core_reserved_gid_alloc(struct mlx5_core_dev *dev, int *gid_index)
if (index < 0)
return index;

- mlx5_core_dbg(dev, "Allodating reserved GID %u\n", index);
+ mlx5_core_dbg(dev, "Allocating reserved GID %u\n", index);
*gid_index = index;
return 0;
}
--
2.11.0

2017-06-30 18:55:11

by Ilan Tayari

Subject: RE: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

> -----Original Message-----
> From: Colin King [mailto:[email protected]]
> Subject: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" ->
> "Allocating"
>
> From: Colin Ian King <[email protected]>
>
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> index 4d0db481f6c4..de2aed44ab85 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> @@ -101,7 +101,7 @@ int mlx5_core_reserved_gid_alloc(struct mlx5_core_dev
> *dev, int *gid_index)
> if (index < 0)
> return index;
>
> - mlx5_core_dbg(dev, "Allodating reserved GID %u\n", index);
> + mlx5_core_dbg(dev, "Allocating reserved GID %u\n", index);
> *gid_index = index;
> return 0;
> }
> --
> 2.11.0

Thank you Colin for the fix.

Reviewed-by: Ilan Tayari <[email protected]>

2017-07-01 21:40:09

by David Miller

Subject: Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

From: Colin King <[email protected]>
Date: Fri, 30 Jun 2017 11:59:22 +0100

> From: Colin Ian King <[email protected]>
>
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks Colin.

Mellanox folks, I don't like how these lib/ objects are built.

I absolutely depend upon being able to try and build individual
object files, by name, in order to quickly smoke-test patches.
Like this:

[davem@kkuri net-next]$ make drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o

But I can't for these files:

scripts/Makefile.build:44: drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile: No such file or directory
make[1]: *** No rule to make target 'drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile'. Stop.
Makefile:1663: recipe for target 'drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o' failed

Please fix this so that I can build all object files by name in this driver
again.

Thanks.

2017-07-02 08:36:09

by Saeed Mahameed

Subject: Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

On Sun, Jul 2, 2017 at 12:40 AM, David Miller <[email protected]> wrote:
> From: Colin King <[email protected]>
> Date: Fri, 30 Jun 2017 11:59:22 +0100
>
>> From: Colin Ian King <[email protected]>
>>
>> Trivial fix to spelling mistake in mlx5_core_dbg debug message
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> Applied, thanks Colin.
>
> Mellanox folks, I don't like how these lib/ objects are built.
>
> I absolutely depend upon being able to try and build individual
> object files, by name, in order to quickly smoke-test patches.
> Like this:
>
> [davem@kkuri net-next]$ make drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o
>
> But I can't for these files:
>
> scripts/Makefile.build:44: drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile: No such file or directory
> make[1]: *** No rule to make target 'drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile'. Stop.
> Makefile:1663: recipe for target 'drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o' failed
>
> Please fix this so that I can build all object files by name in this driver
> again.

Hi Dave,
We are going to provide a fix ASAP.

>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html