2017-06-27 09:10:55

by Arvind Yadav

Subject: [PATCH] sparc: kernel: pmc: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
arch/sparc/kernel/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/pmc.c b/arch/sparc/kernel/pmc.c
index f12b23f..3b26cf6 100644
--- a/arch/sparc/kernel/pmc.c
+++ b/arch/sparc/kernel/pmc.c
@@ -71,7 +71,7 @@ static int pmc_probe(struct platform_device *op)
return 0;
}

-static struct of_device_id pmc_match[] = {
+static const struct of_device_id pmc_match[] = {
{
.name = PMC_OBPNAME,
},
--
1.9.1

2017-07-03 09:53:57

by David Miller

Subject: Re: [PATCH] sparc: kernel: pmc: make of_device_ids const.

From: Arvind Yadav <[email protected]>
Date: Tue, 27 Jun 2017 14:39:58 +0530

> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied.