2017-07-04 18:14:40

by Fengguang Wu

Subject: [PATCH] bio-integrity: fix boolreturn.cocci warnings

block/bio-integrity.c:318:10-11: WARNING: return of 0/1 in function 'bio_integrity_prep' with return type bool

Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: e23947bd76f0 ("bio-integrity: fold bio_integrity_enabled to bio_integrity_prep")
CC: Dmitry Monakhov <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

bio-integrity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/bio-integrity.c
+++ b/block/bio-integrity.c
@@ -315,7 +315,7 @@ bool bio_integrity_prep(struct bio *bio)
bytes, offset);

if (ret == 0)
- return 0;
+ return false;

if (ret < bytes)
break;

2017-07-04 22:12:19

by Jens Axboe

Subject: Re: [PATCH] bio-integrity: fix boolreturn.cocci warnings

On 07/04/2017 12:14 PM, kbuild test robot wrote:
> block/bio-integrity.c:318:10-11: WARNING: return of 0/1 in function 'bio_integrity_prep' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci

Thanks, applied.

--
Jens Axboe