2017-07-05 08:31:08

by Paolo Bonzini

[permalink] [raw]
Subject: [PATCH] virtio_scsi: always read VPD pages for multiqueue too

Multi-queue virtio-scsi uses a different scsi_host_template struct.
Add the .device_alloc field there, too.

Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
Cc: [email protected]
Cc: David Gibson <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
---
drivers/scsi/virtio_scsi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index f8dbfeee6c63..ad1e7f1aba4c 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -826,6 +826,7 @@ static int virtscsi_map_queues(struct Scsi_Host *shost)
.change_queue_depth = virtscsi_change_queue_depth,
.eh_abort_handler = virtscsi_abort,
.eh_device_reset_handler = virtscsi_device_reset,
+ .slave_alloc = virtscsi_device_alloc,

.can_queue = 1024,
.dma_boundary = UINT_MAX,
--
1.8.3.1


2017-07-05 08:44:12

by Fam Zheng

[permalink] [raw]
Subject: Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too

On Wed, 07/05 10:30, Paolo Bonzini wrote:
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
>
> Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
> Cc: [email protected]
> Cc: David Gibson <[email protected]>
> Signed-off-by: Paolo Bonzini <[email protected]>
> ---
> drivers/scsi/virtio_scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index f8dbfeee6c63..ad1e7f1aba4c 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -826,6 +826,7 @@ static int virtscsi_map_queues(struct Scsi_Host *shost)
> .change_queue_depth = virtscsi_change_queue_depth,
> .eh_abort_handler = virtscsi_abort,
> .eh_device_reset_handler = virtscsi_device_reset,
> + .slave_alloc = virtscsi_device_alloc,
>
> .can_queue = 1024,
> .dma_boundary = UINT_MAX,
> --
> 1.8.3.1
>

Reviewed-by: Fam Zheng <[email protected]>

2017-07-11 12:29:10

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too

On Wed, Jul 05, 2017 at 10:30:56AM +0200, Paolo Bonzini wrote:
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
>
> Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
> Cc: [email protected]
> Cc: David Gibson <[email protected]>
> Signed-off-by: Paolo Bonzini <[email protected]>
> ---
> drivers/scsi/virtio_scsi.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <[email protected]>

Attachments:
(No filename) (487.00 B)
 signature.asc (455.00 B)
 Download all attachments

2017-07-12 21:17:04

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too


Paolo,

> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.

Applied to 4.13/scsi-fixes by hand. Thanks!

--
Martin K. Petersen Oracle Linux Engineering