2017-07-19 17:25:00

by Mark Salter

[permalink] [raw]
Subject: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

Rafael,

What do you think of this one? I was submitted a long time ago but
there was never any real resolution to it.


Loc Ho (1):
acpi: apei: Enable APEI multiple GHES source to share an single
external IRQ

drivers/acpi/apei/ghes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--
2.13.3


2017-07-19 19:24:01

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

On Wed, Jul 19, 2017 at 7:24 PM, Mark Salter <[email protected]> wrote:
> Rafael,
>
> What do you think of this one?

Please ask this question to Boris Petkov in the first place.

> I was submitted a long time ago but
> there was never any real resolution to it.
>
>
> Loc Ho (1):
> acpi: apei: Enable APEI multiple GHES source to share an single
> external IRQ
>

Thanks,
Rafael

2017-07-19 20:05:25

by Mark Salter

[permalink] [raw]
Subject: Re: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

On Wed, 2017-07-19 at 21:23 +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 19, 2017 at 7:24 PM, Mark Salter <[email protected]> wrote:
> > Rafael,
> >
> > What do you think of this one?
>
> Please ask this question to Boris Petkov in the first place.

Yes, I should have included Boris. The last time this came up, Boris
said it was up to you. :)

http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401772.html

2017-07-20 04:49:48

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

On Wed, Jul 19, 2017 at 04:05:21PM -0400, Mark Salter wrote:
> Yes, I should have included Boris. The last time this came up, Boris
> said it was up to you. :)
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401772.html

/me goes back and reads the old emails.

So I had some issues with how acpi_gsi_to_irq() returns the irq number
but that required more involved simplification and the submitter was
unsurprisingly reluctant to do it.

That's why it was Rafael's call.

AFAIR.

Also, from looking at the patches, the SOB chain is wrong:

Signed-off-by: Tuan Phan <[email protected]>
Signed-off-by: Loc Ho <[email protected]>

I don't know from that who's the author and who's the submitter.
SubmittingPatches has more info on the whole deal.

So please resubmit updated versions with issues addressed.

Thanks.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

2017-07-20 17:49:11

by Loc Ho

[permalink] [raw]
Subject: Re: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

Hi Borislav/Mark,

> On Wed, Jul 19, 2017 at 04:05:21PM -0400, Mark Salter wrote:
> > Yes, I should have included Boris. The last time this came up, Boris
> > said it was up to you. :)
> >
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401772.html
>
> /me goes back and reads the old emails.
>
> So I had some issues with how acpi_gsi_to_irq() returns the irq number
> but that required more involved simplification and the submitter was
> unsurprisingly reluctant to do it.
>
> That's why it was Rafael's call.
>
> AFAIR.
>
> Also, from looking at the patches, the SOB chain is wrong:
>
> Signed-off-by: Tuan Phan <[email protected]>
> Signed-off-by: Loc Ho <[email protected]>
>
> I don't know from that who's the author and who's the submitter.
> SubmittingPatches has more info on the whole deal.
>
> So please resubmit updated versions with issues addressed.

Tuan and I both worked on the APEI side for X-Gene and for this one,
we both sign off. If you required, I can re-post another version. Or
you can simple pull in v4 2/2 patch -
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/400780.html

-Loc

2017-07-20 18:00:54

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH 0/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

On Thu, Jul 20, 2017 at 10:49:08AM -0700, Loc Ho wrote:
> Tuan and I both worked on the APEI side for X-Gene and for this one,
> we both sign off.

There's no such thing as "both sign off". See the document I mentioned
before.

> If you required, I can re-post another version.

Yes please.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--