2017-07-20 15:50:17

by Arnd Bergmann

Subject: [PATCH 02/12] ARM: ep93xx: use ARM_PATCH_PHYS_VIRT

Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT
when possible, but that fails for NOMMU or XIP_KERNEL configurations.
Using 'imply' instead of 'select' gets this right and only uses
the symbol when we don't have to hardcode the address anyway.

Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d6e6f40addf6..db856355bd24 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -406,7 +406,7 @@ config ARCH_EP93XX
bool "EP93xx-based"
select ARCH_HAS_HOLES_MEMORYMODEL
select ARM_AMBA
- select ARM_PATCH_PHYS_VIRT
+ imply ARM_PATCH_PHYS_VIRT
select ARM_VIC
select AUTO_ZRELADDR
select CLKDEV_LOOKUP
--
2.9.0

2017-07-20 16:07:12

by Alexander Sverdlin

Subject: Re: [PATCH 02/12] ARM: ep93xx: use ARM_PATCH_PHYS_VIRT

On Thu Jul 20 17:49:27 2017 Arnd Bergmann <[email protected]> wrote:
> Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT
> when possible, but that fails for NOMMU or XIP_KERNEL configurations.
> Using 'imply' instead of 'select' gets this right and only uses
> the symbol when we don't have to hardcode the address anyway.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Alexander Sverdlin <[email protected]>

> ---
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index d6e6f40addf6..db856355bd24 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -406,7 +406,7 @@ config ARCH_EP93XX
>      bool "EP93xx-based"
>      select ARCH_HAS_HOLES_MEMORYMODEL
>      select ARM_AMBA
> -    select ARM_PATCH_PHYS_VIRT
> +    imply ARM_PATCH_PHYS_VIRT
>      select ARM_VIC
>      select AUTO_ZRELADDR
>      select CLKDEV_LOOKUP
> --
> 2.9.0
>

2017-08-02 12:29:55

by Linus Walleij

Subject: Re: [PATCH 02/12] ARM: ep93xx: use ARM_PATCH_PHYS_VIRT

On Thu, Jul 20, 2017 at 5:49 PM, Arnd Bergmann <[email protected]> wrote:

> Just like ARCH_MULTIPLATFORM, we want to use ARM_PATCH_PHYS_VIRT
> when possible, but that fails for NOMMU or XIP_KERNEL configurations.
> Using 'imply' instead of 'select' gets this right and only uses
> the symbol when we don't have to hardcode the address anyway.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Linus Walleij <[email protected]>

I assume you will apply this directly to ARM SoC.

Yours,
Linus Walleij