2017-07-24 09:59:44

by Bryan O'Donoghue

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

commit bdfb95c4baab ("staging: greybus: remove timesync protocol support")
commit 1e029b836108 ("staging: greybus: arche: remove timesync remains")

Subtract timesync from greybus/staging but haven't updated MAINTAINERS
appropriately. Fix that omission now.

Signed-off-by: Bryan O'Donoghue <[email protected]>
---
MAINTAINERS | 2 --
1 file changed, 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f66488d..ca9e29e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5830,8 +5830,6 @@ GREYBUS LOOBACK/TIME PROTOCOLS DRIVERS
M: Bryan O'Donoghue <[email protected]>
S: Maintained
F: drivers/staging/greybus/loopback.c
-F: drivers/staging/greybus/timesync.c
-F: drivers/staging/greybus/timesync_platform.c

GREYBUS PLATFORM DRIVERS
M: Vaibhav Hiremath <[email protected]>
--
2.7.4


2017-07-24 11:27:53

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On Mon, Jul 24, 2017 at 11:05:49AM +0100, Bryan O'Donoghue wrote:
> commit bdfb95c4baab ("staging: greybus: remove timesync protocol support")
> commit 1e029b836108 ("staging: greybus: arche: remove timesync remains")
>
> Subtract timesync from greybus/staging but haven't updated MAINTAINERS
> appropriately. Fix that omission now.
>
> Signed-off-by: Bryan O'Donoghue <[email protected]>
> ---
> MAINTAINERS | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f66488d..ca9e29e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5830,8 +5830,6 @@ GREYBUS LOOBACK/TIME PROTOCOLS DRIVERS
> M: Bryan O'Donoghue <[email protected]>
> S: Maintained
> F: drivers/staging/greybus/loopback.c
> -F: drivers/staging/greybus/timesync.c
> -F: drivers/staging/greybus/timesync_platform.c

Joe reported these, and a number of other obsolete or misspelled entries
in MAINTAINERS three days ago but wanted to get his sorting patch in
before addressing them. I'm not sure whether the intention was to fix
them all up in one go or to do it like this.

But either way,

Acked-by: Johan Hovold <[email protected]>

Thanks,
Johan

2017-07-24 15:13:07

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On 24/07/17 12:27, Johan Hovold wrote:
> On Mon, Jul 24, 2017 at 11:05:49AM +0100, Bryan O'Donoghue wrote:
>> commit bdfb95c4baab ("staging: greybus: remove timesync protocol support")
>> commit 1e029b836108 ("staging: greybus: arche: remove timesync remains")
>>
>> Subtract timesync from greybus/staging but haven't updated MAINTAINERS
>> appropriately. Fix that omission now.
>>
>> Signed-off-by: Bryan O'Donoghue <[email protected]>
>> ---
>> MAINTAINERS | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f66488d..ca9e29e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -5830,8 +5830,6 @@ GREYBUS LOOBACK/TIME PROTOCOLS DRIVERS
>> M: Bryan O'Donoghue <[email protected]>
>> S: Maintained
>> F: drivers/staging/greybus/loopback.c
>> -F: drivers/staging/greybus/timesync.c
>> -F: drivers/staging/greybus/timesync_platform.c
>
> Joe reported these, and a number of other obsolete or misspelled entries
> in MAINTAINERS three days ago but wanted to get his sorting patch in
> before addressing them. I'm not sure whether the intention was to fix
> them all up in one go or to do it like this.
>
> But either way,
>
> Acked-by: Johan Hovold <[email protected]>
>
> Thanks,
> Johan
>

Already applied I believe.

commit 7683e9e529258d01ce99216ad3be21f59eff83ec
Author: Linus Torvalds <[email protected]>
Date: Sun Jul 23 16:06:21 2017 -0700

Properly alphabetize MAINTAINERS file

2017-07-24 15:16:31

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On Mon, 2017-07-24 at 16:19 +0100, Bryan O'Donoghue wrote:
> On 24/07/17 12:27, Johan Hovold wrote:
> > On Mon, Jul 24, 2017 at 11:05:49AM +0100, Bryan O'Donoghue wrote:
> > > commit bdfb95c4baab ("staging: greybus: remove timesync protocol support")
> > > commit 1e029b836108 ("staging: greybus: arche: remove timesync remains")
> > >
> > > Subtract timesync from greybus/staging but haven't updated MAINTAINERS
> > > appropriately. Fix that omission now.
> > >
> > > Signed-off-by: Bryan O'Donoghue <[email protected]>
> > > ---
> > > MAINTAINERS | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f66488d..ca9e29e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -5830,8 +5830,6 @@ GREYBUS LOOBACK/TIME PROTOCOLS DRIVERS
> > > M: Bryan O'Donoghue <[email protected]>
> > > S: Maintained
> > > F: drivers/staging/greybus/loopback.c
> > > -F: drivers/staging/greybus/timesync.c
> > > -F: drivers/staging/greybus/timesync_platform.c
> >
> > Joe reported these, and a number of other obsolete or misspelled entries
> > in MAINTAINERS three days ago but wanted to get his sorting patch in
> > before addressing them. I'm not sure whether the intention was to fix
> > them all up in one go or to do it like this.
> >
> > But either way,
> >
> > Acked-by: Johan Hovold <[email protected]>
> >
> > Thanks,
> > Johan
> >
>
> Already applied I believe.
>
> commit 7683e9e529258d01ce99216ad3be21f59eff83ec
> Author: Linus Torvalds <[email protected]>
> Date: Sun Jul 23 16:06:21 2017 -0700
>
> Properly alphabetize MAINTAINERS file

No, the sorting did not remove or update invalid F: entries.
It just moved sections around.

2017-07-24 15:26:13

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On 24/07/17 16:16, Joe Perches wrote:
> On Mon, 2017-07-24 at 16:19 +0100, Bryan O'Donoghue wrote:
>> On 24/07/17 12:27, Johan Hovold wrote:
>>> On Mon, Jul 24, 2017 at 11:05:49AM +0100, Bryan O'Donoghue wrote:
>>>> commit bdfb95c4baab ("staging: greybus: remove timesync protocol support")
>>>> commit 1e029b836108 ("staging: greybus: arche: remove timesync remains")
>>>>
>>>> Subtract timesync from greybus/staging but haven't updated MAINTAINERS
>>>> appropriately. Fix that omission now.
>>>>
>>>> Signed-off-by: Bryan O'Donoghue <[email protected]>
>>>> ---
>>>> MAINTAINERS | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index f66488d..ca9e29e 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -5830,8 +5830,6 @@ GREYBUS LOOBACK/TIME PROTOCOLS DRIVERS
>>>> M: Bryan O'Donoghue <[email protected]>
>>>> S: Maintained
>>>> F: drivers/staging/greybus/loopback.c
>>>> -F: drivers/staging/greybus/timesync.c
>>>> -F: drivers/staging/greybus/timesync_platform.c
>>>
>>> Joe reported these, and a number of other obsolete or misspelled entries
>>> in MAINTAINERS three days ago but wanted to get his sorting patch in
>>> before addressing them. I'm not sure whether the intention was to fix
>>> them all up in one go or to do it like this.
>>>
>>> But either way,
>>>
>>> Acked-by: Johan Hovold <[email protected]>
>>>
>>> Thanks,
>>> Johan
>>>
>>
>> Already applied I believe.
>>
>> commit 7683e9e529258d01ce99216ad3be21f59eff83ec
>> Author: Linus Torvalds <[email protected]>
>> Date: Sun Jul 23 16:06:21 2017 -0700
>>
>> Properly alphabetize MAINTAINERS file
>
> No, the sorting did not remove or update invalid F: entries.
> It just moved sections around.
>

Ah yes I remember now, those are two separate patches. Anyway my greybus
filter caught your mail which is what prompted me to send this out, I
wasn't sure if you wanted others to clean up their own crap, or if you
wanted to yourself.

Feel free to add my Acked-by if you perfer to send the whole lot out as one.

---
bod

2017-07-24 15:31:32

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On Mon, 2017-07-24 at 16:32 +0100, Bryan O'Donoghue wrote:
> Ah yes I remember now, those are two separate patches. Anyway my greybus
> filter caught your mail which is what prompted me to send this out, I
> wasn't sure if you wanted others to clean up their own crap, or if you
> wanted to yourself.

Everyone learns in kindergarten to clean up their own messes.
And my sweet wife tells me I'm not very good at it.

2017-07-24 15:45:01

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Remove dead greybus/timesync entry

On 24/07/17 16:31, Joe Perches wrote:
> On Mon, 2017-07-24 at 16:32 +0100, Bryan O'Donoghue wrote:
>> Ah yes I remember now, those are two separate patches. Anyway my greybus
>> filter caught your mail which is what prompted me to send this out, I
>> wasn't sure if you wanted others to clean up their own crap, or if you
>> wanted to yourself.
>
> Everyone learns in kindergarten to clean up their own messes.
> And my sweet wife tells me I'm not very good at it.
>

Personally I'm 100% fine living in reams of trash/take-away
boxes/kitty-litter.

/meh - TMI