2017-07-25 15:43:07

by Arnd Bergmann

Subject: [PATCH] mtd: remove unused variable in mtdswap

The only user of this variable was removed, leading to a
new harmless warning:

drivers/mtd/mtdswap.c: In function 'mtdswap_add_debugfs':
drivers/mtd/mtdswap.c:1317:17: error: unused variable 'dev' [-Werror=unused-variable]

This removes the variable as well.

Fixes: e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/mtd/mtdswap.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index 6b17932fe557..7d9080e33865 100644
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -1313,9 +1313,6 @@ static const struct file_operations mtdswap_fops = {

static int mtdswap_add_debugfs(struct mtdswap_dev *d)
{
- struct gendisk *gd = d->mbd_dev->disk;
- struct device *dev = disk_to_dev(gd);
-
struct dentry *root = d->mtd->dbg.dfs_dir;
struct dentry *dent;

--
2.9.0

2017-07-25 17:02:18

by Brian Norris

Subject: Re: [PATCH] mtd: remove unused variable in mtdswap

On Tue, Jul 25, 2017 at 05:41:58PM +0200, Arnd Bergmann wrote:
> The only user of this variable was removed, leading to a
> new harmless warning:
>
> drivers/mtd/mtdswap.c: In function 'mtdswap_add_debugfs':
> drivers/mtd/mtdswap.c:1317:17: error: unused variable 'dev' [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Fixes: e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
> Signed-off-by: Arnd Bergmann <[email protected]>

I beat you to it:

https://patchwork.ozlabs.org/patch/793136/
[PATCH] mtd: mtdswap: remove unused variables 'dev' and 'gd'