2017-08-03 12:07:43

by Cihangir Akturk

Subject: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() adn should not be
used by new code. So convert all users of compatibility functions to use
the new APIs.

Signed-off-by: Cihangir Akturk <[email protected]>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index 1124200..fc3f910 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p)
struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);

if (plane->base.fb)
- drm_framebuffer_unreference(plane->base.fb);
+ drm_framebuffer_put(plane->base.fb);

drm_plane_cleanup(p);
}
@@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state);

if (state->base.fb)
- drm_framebuffer_unreference(state->base.fb);
+ drm_framebuffer_put(state->base.fb);

kfree(state);
p->state = NULL;
@@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p)
}

if (copy->base.fb)
- drm_framebuffer_reference(copy->base.fb);
+ drm_framebuffer_get(copy->base.fb);

return &copy->base;
}
@@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p,
}

if (s->fb)
- drm_framebuffer_unreference(s->fb);
+ drm_framebuffer_put(s->fb);

kfree(state);
}
--
2.7.4

2017-08-03 12:10:53

by Boris Brezillon

Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers

On Thu, 3 Aug 2017 14:58:20 +0300
Cihangir Akturk <[email protected]> wrote:

> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() adn should not be

s/adn/and/

> used by new code. So convert all users of compatibility functions to use
> the new APIs.
>
> Signed-off-by: Cihangir Akturk <[email protected]>

Acked-by: Boris Brezillon <[email protected]>

> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index 1124200..fc3f910 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p)
> struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
>
> if (plane->base.fb)
> - drm_framebuffer_unreference(plane->base.fb);
> + drm_framebuffer_put(plane->base.fb);
>
> drm_plane_cleanup(p);
> }
> @@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
> state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state);
>
> if (state->base.fb)
> - drm_framebuffer_unreference(state->base.fb);
> + drm_framebuffer_put(state->base.fb);
>
> kfree(state);
> p->state = NULL;
> @@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p)
> }
>
> if (copy->base.fb)
> - drm_framebuffer_reference(copy->base.fb);
> + drm_framebuffer_get(copy->base.fb);
>
> return &copy->base;
> }
> @@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p,
> }
>
> if (s->fb)
> - drm_framebuffer_unreference(s->fb);
> + drm_framebuffer_put(s->fb);
>
> kfree(state);
> }

2017-08-03 14:55:42

by Boris Brezillon

Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers

On Thu, 3 Aug 2017 14:10:50 +0200
Boris Brezillon <[email protected]> wrote:

> On Thu, 3 Aug 2017 14:58:20 +0300
> Cihangir Akturk <[email protected]> wrote:
>
> > drm_*_reference() and drm_*_unreference() functions are just
> > compatibility alias for drm_*_get() and drm_*_put() adn should not be
>
> s/adn/and/
>
> > used by new code. So convert all users of compatibility functions to use
> > the new APIs.
> >
> > Signed-off-by: Cihangir Akturk <[email protected]>
>
> Acked-by: Boris Brezillon <[email protected]>

Applied to drm-misc-next (as suggested by Daniel) after fixing the
typo.

Thanks,

Boris

>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index 1124200..fc3f910 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p)
> > struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
> >
> > if (plane->base.fb)
> > - drm_framebuffer_unreference(plane->base.fb);
> > + drm_framebuffer_put(plane->base.fb);
> >
> > drm_plane_cleanup(p);
> > }
> > @@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
> > state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state);
> >
> > if (state->base.fb)
> > - drm_framebuffer_unreference(state->base.fb);
> > + drm_framebuffer_put(state->base.fb);
> >
> > kfree(state);
> > p->state = NULL;
> > @@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p)
> > }
> >
> > if (copy->base.fb)
> > - drm_framebuffer_reference(copy->base.fb);
> > + drm_framebuffer_get(copy->base.fb);
> >
> > return &copy->base;
> > }
> > @@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p,
> > }
> >
> > if (s->fb)
> > - drm_framebuffer_unreference(s->fb);
> > + drm_framebuffer_put(s->fb);
> >
> > kfree(state);
> > }
>