2017-08-05 01:51:40

by Amitoj Kaur Chawla

Subject: [PATCH] imon: constify attribute_group structures

Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.

File size before:
text data bss dec hex filename
36981 16776 960 54717 d5bd drivers/media/rc/imon.o

File size after:
text data bss dec hex filename
37173 16584 960 54717 d5bd drivers/media/rc/imon.o

This change was made with the help of Coccinelle.

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
---
drivers/media/rc/imon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index bd76534..717ba78 100644
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -911,7 +911,7 @@ static struct attribute *imon_display_sysfs_entries[] = {
NULL
};

-static struct attribute_group imon_display_attr_group = {
+static const struct attribute_group imon_display_attr_group = {
.attrs = imon_display_sysfs_entries
};

@@ -920,7 +920,7 @@ static struct attribute *imon_rf_sysfs_entries[] = {
NULL
};

-static struct attribute_group imon_rf_attr_group = {
+static const struct attribute_group imon_rf_attr_group = {
.attrs = imon_rf_sysfs_entries
};

--
2.7.4

2017-08-10 21:55:58

by Sean Young

Subject: Re: [PATCH] imon: constify attribute_group structures

On Fri, Aug 04, 2017 at 09:51:38PM -0400, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.

I'm afraid the exact same patch has already been submitted before.

http://www.spinics.net/lists/linux-media/msg118090.html


Sean

>
> File size before:
> text data bss dec hex filename
> 36981 16776 960 54717 d5bd drivers/media/rc/imon.o
>
> File size after:
> text data bss dec hex filename
> 37173 16584 960 54717 d5bd drivers/media/rc/imon.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>
> ---
> drivers/media/rc/imon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
> index bd76534..717ba78 100644
> --- a/drivers/media/rc/imon.c
> +++ b/drivers/media/rc/imon.c
> @@ -911,7 +911,7 @@ static struct attribute *imon_display_sysfs_entries[] = {
> NULL
> };
>
> -static struct attribute_group imon_display_attr_group = {
> +static const struct attribute_group imon_display_attr_group = {
> .attrs = imon_display_sysfs_entries
> };
>
> @@ -920,7 +920,7 @@ static struct attribute *imon_rf_sysfs_entries[] = {
> NULL
> };
>
> -static struct attribute_group imon_rf_attr_group = {
> +static const struct attribute_group imon_rf_attr_group = {
> .attrs = imon_rf_sysfs_entries
> };
>
> --
> 2.7.4