From: Hoeze <[email protected]>
This patch adds a missing PCI ID to the Intel LPSS driver.
It fixes a bug causing the touchpad of the Lenovo Yoga 720-15 not to be recognized.
See also bug 1700657 on bugs.launchpad.net.
Many thanks to CoolStar, who found this solution!
Reported-by: CoolStar <[email protected]>
Tested-by: Mike Schwartz <[email protected]>
Tested-by: Björn Dahlgren <[email protected]>
Signed-off-by: Florian R. Hölzlwimmer <[email protected]>
---
drivers/mfd/intel-lpss-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index ad388bb0..d1c46de8 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -221,6 +221,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
{ PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
{ PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },
{ PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
/* KBL-H */
{ PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },
--
2.14.1
Hi all,
This has worked its way from a pull request on GitHub through to this
patch, which is a great credit to the determination and effort of
Florian.
I think it's an excellent first contribution.
Reviewed-by: Daniel Axtens <[email protected]>
Regards,
Daniel
Hoeze <[email protected]> writes:
> From: Hoeze <[email protected]>
>
> This patch adds a missing PCI ID to the Intel LPSS driver.
> It fixes a bug causing the touchpad of the Lenovo Yoga 720-15 not to be recognized.
> See also bug 1700657 on bugs.launchpad.net.
>
> Many thanks to CoolStar, who found this solution!
>
> Reported-by: CoolStar <[email protected]>
> Tested-by: Mike Schwartz <[email protected]>
> Tested-by: Björn Dahlgren <[email protected]>
> Signed-off-by: Florian R. Hölzlwimmer <[email protected]>
> ---
> drivers/mfd/intel-lpss-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index ad388bb0..d1c46de8 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -221,6 +221,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
> { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
> { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },
> { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
> /* KBL-H */
> { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },
> --
> 2.14.1
Hi Florian,
As Daniel said, good work on figuring out how to get this far!
There's a couple of minor issues with the formatting of this patch.
Firstly, as Lee said in response to the last version, you should change
the summary line of the commit to indicate the contents of the patch
more accurately.
Based on what I see in the git log, I'd suggest:
"mfd: intel-lpss: Add missing PCI ID"
The previous commits to this file also mention the type of chipset - I
*think* this is Sunrise Point, but I don't work for Intel. :)
Don't mention the Lenovo touchpad in the summary - in the main body of
the commit message is better.
On 13/08/17 06:16, Hoeze wrote:
> From: Hoeze <[email protected]>
The name and email here is what's going to appear in the git commit log
as the author of the commit. Generally, it should be the same as both
the details in your Signed-off-by line, and the email should be the same
as the email address you're sending from. If the name/email address in
the commit is the same as the name/email address you're sending from,
git send-email will actually skip this line completely.
You should probably try:
$ git config --global user.name "Florian R. Hölzlwimmer"
$ git config --global user.email "[email protected]"
$ git commit --amend --reset-author
This will set your details in your git configuration, and then re-create
the last commit using the correct authorship details.
If you then re-send it, it should skip this From: line and everything
should be fine.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited