2017-08-09 17:20:45

by Gustavo A. R. Silva

Subject: [PATCH] mtd: nand: mtk: fix error return code in mtk_ecc_probe()

platform_get_irq() returns an error code, but the mtk_ecc driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/mtd/nand/mtk_ecc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c
index 6c3a4aa..7f3b065 100644
--- a/drivers/mtd/nand/mtk_ecc.c
+++ b/drivers/mtd/nand/mtk_ecc.c
@@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "failed to get irq\n");
- return -EINVAL;
+ dev_err(dev, "failed to get irq: %d\n", irq);
+ return irq;
}

ret = dma_set_mask(dev, DMA_BIT_MASK(32));
--
2.5.0

2017-08-13 08:02:16

by Boris Brezillon

Subject: Re: [PATCH] mtd: nand: mtk: fix error return code in mtk_ecc_probe()

Le Wed, 9 Aug 2017 11:35:21 -0500,
"Gustavo A. R. Silva" <[email protected]> a écrit :

> platform_get_irq() returns an error code, but the mtk_ecc driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.

Applied.

Thanks,

Boris

>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/mtd/nand/mtk_ecc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c
> index 6c3a4aa..7f3b065 100644
> --- a/drivers/mtd/nand/mtk_ecc.c
> +++ b/drivers/mtd/nand/mtk_ecc.c
> @@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "failed to get irq\n");
> - return -EINVAL;
> + dev_err(dev, "failed to get irq: %d\n", irq);
> + return irq;
> }
>
> ret = dma_set_mask(dev, DMA_BIT_MASK(32));