2017-08-11 14:28:42

by Florian Weimer

[permalink] [raw]
Subject: [PATCH] uapi/linux/quota.h: Do not include linux/errno.h

linux/errno.h is very sensitive to coordination with libc headers.
Nothing in linux/quota.h needs it, so this change allows using
this header in more contexts.

Signed-off-by: Florian Weimer <[email protected]>
---
include/uapi/linux/quota.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/uapi/linux/quota.h b/include/uapi/linux/quota.h
index 4d2489ef6f10..f17c9636a859 100644
--- a/include/uapi/linux/quota.h
+++ b/include/uapi/linux/quota.h
@@ -33,7 +33,6 @@
#ifndef _UAPI_LINUX_QUOTA_
#define _UAPI_LINUX_QUOTA_

-#include <linux/errno.h>
#include <linux/types.h>

#define __DQUOT_VERSION__ "dquot_6.6.0"
--
2.13.4


2017-08-14 09:54:42

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] uapi/linux/quota.h: Do not include linux/errno.h

On Fri 11-08-17 16:24:15, Florian Weimer wrote:
> linux/errno.h is very sensitive to coordination with libc headers.
> Nothing in linux/quota.h needs it, so this change allows using
> this header in more contexts.
>
> Signed-off-by: Florian Weimer <[email protected]>

Thanks! Added to my tree.

Honza


> ---
> include/uapi/linux/quota.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/quota.h b/include/uapi/linux/quota.h
> index 4d2489ef6f10..f17c9636a859 100644
> --- a/include/uapi/linux/quota.h
> +++ b/include/uapi/linux/quota.h
> @@ -33,7 +33,6 @@
> #ifndef _UAPI_LINUX_QUOTA_
> #define _UAPI_LINUX_QUOTA_
>
> -#include <linux/errno.h>
> #include <linux/types.h>
>
> #define __DQUOT_VERSION__ "dquot_6.6.0"
> --
> 2.13.4
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR