2017-08-17 10:30:46

by Michael Ellerman

[permalink] [raw]
Subject: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

The sysctl documentation states that the JIT is only available on
x86_64, which is no longer correct.

Update the list, and break it out to indicate which architectures
support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT
(HAVE_EBPF_JIT).

Signed-off-by: Michael Ellerman <[email protected]>
---
Documentation/sysctl/net.txt | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)

v2: Split the list based on cBPF vs eBPF.

diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/net.txt
index 14db18c970b1..b9c3c6078010 100644
--- a/Documentation/sysctl/net.txt
+++ b/Documentation/sysctl/net.txt
@@ -36,8 +36,23 @@ bpf_jit_enable
--------------

This enables Berkeley Packet Filter Just in Time compiler.
-Currently supported on x86_64 architecture, bpf_jit provides a framework
-to speed packet filtering, the one used by tcpdump/libpcap for example.
+
+There are two flavors of JIT, the new eBPF JIT supported on:
+ - x86_64
+ - arm64
+ - ppc64
+ - sparc64
+ - mips64
+
+And the older cBPF JIT supported on:
+ - arm
+ - mips
+ - ppc
+ - sparc
+
+The BPF JIT provides a framework to speed packet filtering, the one used by
+tcpdump/libpcap for example.
+
Values :
0 - disable the JIT (default value)
1 - enable the JIT
--
2.7.4


2017-08-17 11:50:42

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

On 08/17/2017 12:30 PM, Michael Ellerman wrote:
> The sysctl documentation states that the JIT is only available on
> x86_64, which is no longer correct.
>
> Update the list, and break it out to indicate which architectures
> support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT
> (HAVE_EBPF_JIT).
>
> Signed-off-by: Michael Ellerman <[email protected]>

The last paragraph speaking about tcpdump, I can take care of
later, also given the patch is about updating list of archs, so
lgtm, thanks!

Acked-by: Daniel Borkmann <[email protected]>

2017-08-17 17:09:56

by David Miller

[permalink] [raw]
Subject: Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

From: Michael Ellerman <[email protected]>
Date: Thu, 17 Aug 2017 20:30:39 +1000

> The sysctl documentation states that the JIT is only available on
> x86_64, which is no longer correct.
>
> Update the list, and break it out to indicate which architectures
> support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT
> (HAVE_EBPF_JIT).
>
> Signed-off-by: Michael Ellerman <[email protected]>

Applied, thanks Michael.

2017-08-18 01:27:10

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

Daniel Borkmann <[email protected]> writes:

> On 08/17/2017 12:30 PM, Michael Ellerman wrote:
>> The sysctl documentation states that the JIT is only available on
>> x86_64, which is no longer correct.
>>
>> Update the list, and break it out to indicate which architectures
>> support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT
>> (HAVE_EBPF_JIT).
>>
>> Signed-off-by: Michael Ellerman <[email protected]>
>
> The last paragraph speaking about tcpdump, I can take care of
> later, also given the patch is about updating list of archs, so
> lgtm, thanks!

Thanks.

cheers