2017-08-17 12:06:08

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] i2c: taos-evm: constify serio_device_id

serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/i2c/busses/i2c-taos-evm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
index 210ca82..addd90a 100644
--- a/drivers/i2c/busses/i2c-taos-evm.c
+++ b/drivers/i2c/busses/i2c-taos-evm.c
@@ -291,7 +291,7 @@ static void taos_disconnect(struct serio *serio)
dev_info(&serio->dev, "Disconnected from TAOS EVM\n");
}

-static struct serio_device_id taos_serio_ids[] = {
+static const struct serio_device_id taos_serio_ids[] = {
{
.type = SERIO_RS232,
.proto = SERIO_TAOSEVM,
--
2.7.4


2017-08-17 15:37:27

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: taos-evm: constify serio_device_id

On Thu, Aug 17, 2017 at 05:35:52PM +0530, Arvind Yadav wrote:
> serio_device_id are not supposed to change at runtime. All functions
> working with serio_device_id provided by <linux/serio.h> work with
> const serio_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (359.00 B)
signature.asc (833.00 B)
Download all attachments