2017-08-19 06:52:00

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 0/5] constify net eisa_device_id

eisa_device_id are not supposed to change at runtime. All functions
working with eisa_device_id provided by <linux/eisa.h> work with
const eisa_device_id. So mark the non-const structs as const.

Arvind Yadav (5):
[PATCH 1/5] net: 3c509: constify eisa_device_id
[PATCH 2/5] net: 3c59x: constify eisa_device_id
[PATCH 3/5] net: de4x5: constify eisa_device_id
[PATCH 4/5] net: hp100: constify eisa_device_id
[PATCH 5/5] net: defxx: constify eisa_device_id

drivers/net/ethernet/3com/3c509.c | 2 +-
drivers/net/ethernet/3com/3c59x.c | 2 +-
drivers/net/ethernet/dec/tulip/de4x5.c | 2 +-
drivers/net/ethernet/hp/hp100.c | 2 +-
drivers/net/fddi/defxx.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)

--
2.7.4


2017-08-19 06:52:04

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 1/5] net: 3c509: constify eisa_device_id

eisa_device_id are not supposed to change at runtime. All functions
working with eisa_device_id provided by <linux/eisa.h> work with
const eisa_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/net/ethernet/3com/3c509.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
index 077d01d..b223769 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -474,7 +474,7 @@ static int pnp_registered;
#endif /* CONFIG_PNP */

#ifdef CONFIG_EISA
-static struct eisa_device_id el3_eisa_ids[] = {
+static const struct eisa_device_id el3_eisa_ids[] = {
{ "TCM5090" },
{ "TCM5091" },
{ "TCM5092" },
--
2.7.4

2017-08-20 00:14:03

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 0/5] constify net eisa_device_id

From: Arvind Yadav <[email protected]>
Date: Sat, 19 Aug 2017 12:21:42 +0530

> eisa_device_id are not supposed to change at runtime. All functions
> working with eisa_device_id provided by <linux/eisa.h> work with
> const eisa_device_id. So mark the non-const structs as const.

Series applied, thanks.