2017-08-16 09:17:19

by Bhumika Goyal

[permalink] [raw]
Subject: [PATCH 0/2] [media]: make snd_kcontrol_new const

Make these const. Done using Coccinelle.

Bhumika Goyal (2):
[media] cx88: make snd_kcontrol_new const
[media] solo6x10: make snd_kcontrol_new const

drivers/media/pci/cx88/cx88-alsa.c | 2 +-
drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--
1.9.1


2017-08-16 09:18:06

by Bhumika Goyal

[permalink] [raw]
Subject: [PATCH 1/2] [media] cx88: make snd_kcontrol_new const

Make this const as it only passed as the 1st argument to the function
snd_ctl_new1, which is of type const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/media/pci/cx88/cx88-alsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88-alsa.c
index c81fe46..9740326 100644
--- a/drivers/media/pci/cx88/cx88-alsa.c
+++ b/drivers/media/pci/cx88/cx88-alsa.c
@@ -799,7 +799,7 @@ static int snd_cx88_alc_put(struct snd_kcontrol *kcontrol,
return 0;
}

-static struct snd_kcontrol_new snd_cx88_alc_switch = {
+static const struct snd_kcontrol_new snd_cx88_alc_switch = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "Line-In ALC Switch",
.info = snd_ctl_boolean_mono_info,
--
1.9.1

2017-08-16 09:18:12

by Bhumika Goyal

[permalink] [raw]
Subject: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const

Make this const as it is only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
index 3ca9470..81be1b8 100644
--- a/drivers/media/pci/solo6x10/solo6x10-g723.c
+++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
@@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
return 1;
}

-static struct snd_kcontrol_new snd_solo_capture_volume = {
+static const struct snd_kcontrol_new snd_solo_capture_volume = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "Capture Volume",
.info = snd_solo_capture_volume_info,
--
1.9.1

2017-08-21 12:14:07

by Ismael Luceno

[permalink] [raw]
Subject: Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const

On 16/Aug/2017 14:47, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
> index 3ca9470..81be1b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
> @@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
> return 1;
> }
>
> -static struct snd_kcontrol_new snd_solo_capture_volume = {
> +static const struct snd_kcontrol_new snd_solo_capture_volume = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Capture Volume",
> .info = snd_solo_capture_volume_info,
> --
> 1.9.1
>

Signed-off-by: Ismael Luceno <[email protected]>


Attachments:
(No filename) (959.00 B)
signature.asc (833.00 B)
Download all attachments