2017-07-31 09:19:47

by RishabhHardas

[permalink] [raw]
Subject: [PATCH] staging/ccree: Declare compiled out fuctions static inline

From: RishabhHardas <[email protected]>

Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be made static. This patch makes both the symbols
static inline, to remove the warnings.

Signed-off-by: RishabhHardas <[email protected]>
---
drivers/staging/ccree/ssi_fips.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,1 +40,1 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
}

static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

#endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1


2017-08-01 12:35:46

by Gilad Ben-Yossef

[permalink] [raw]
Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Mon, Jul 31, 2017 at 12:17 PM, RishabhHardas
<[email protected]> wrote:
> From: RishabhHardas <[email protected]>
>
> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> that they were not declared and need to be made static. This patch makes both the symbols
> static inline, to remove the warnings.
>
> Signed-off-by: RishabhHardas <[email protected]>

Acked-by: Gilad Ben-Yossef <[email protected]>

Thanks,
Gilad



--
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru

2017-08-16 22:09:09

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> From: RishabhHardas <[email protected]>
>
> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> that they were not declared and need to be made static. This patch makes both the symbols
> static inline, to remove the warnings.
>
> Signed-off-by: RishabhHardas <[email protected]>

I doubt you sign your name on legal documents without a ' ' somewhere in
it :(

Please fix up and resend.

thanks,

greg k-h

2017-08-22 11:21:35

by Rishabh Hardas

[permalink] [raw]
Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote:
> On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> > From: RishabhHardas <[email protected]>
> >
> > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> > that they were not declared and need to be made static. This patch makes both the symbols
> > static inline, to remove the warnings.
> >
> > Signed-off-by: RishabhHardas <[email protected]>
>
> I doubt you sign your name on legal documents without a ' ' somewhere in
> it :(
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
From: Rishabh Hardas <[email protected]>

Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be made static. This patch makes both the symbols
static inline, to remove the warnings.

Signed-off-by: Rishabh Hardas <[email protected]>
---
drivers/staging/ccree/ssi_fips.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,1 +40,1 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
}

static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

#endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

2017-08-22 13:41:15

by Rishabh Hardas

[permalink] [raw]
Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote:
> On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> > From: RishabhHardas <[email protected]>
> >
> > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> > that they were not declared and need to be made static. This patch makes both the symbols
> > static inline, to remove the warnings.
> >
> > Signed-off-by: RishabhHardas <[email protected]>
>
> I doubt you sign your name on legal documents without a ' ' somewhere in
> it :(
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h

>From 717ec264a6212b8526c381d3673dd0ee45352266 Mon Sep 17 00:00:00 2001
From: Rishabh Hardas <[email protected]>
Date: Tue, 22 Aug 2017 18:56:45 +0530
Subject: [PATCH v2] staging/ccree: Declare compiled out fuctions static inline

Signed-off-by: Rishabh Hardas <[email protected]>
---

Changes in v2:
Corrected my Name.
drivers/staging/ccree/ssi_fips.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,8 +40,8 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
}

static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

#endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

2017-08-22 13:54:18

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

Try saving this email and then do `cat email.txt | git am`. It is
corrupted. This is not how to send a v2 patch. Please read:

https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

Look through the email archives for examples of other v2 patches.

regards,
dan carpenter