2017-08-21 03:37:04

by Jun Gao

[permalink] [raw]
Subject: [PATCH v4 0/3] Add i2c dt-binding and compatible for Mediatek MT7622 SoC

This patch series based on v4.13-rc1, include i2c binding file information
formats modification, MT7622 i2c dt-binding and compatible.

changes since v3:
- Split the formats modification into another patch

changes since v2:
- Remove all the length settings from mt7622_i2c_quirks

changes since v1:
- Modify commit message
- Revise dt-binding documentation

Jun Gao (3):
dt-bindings: i2c: modify information formats
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622

Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 15 ++++++++-------
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
2 files changed, 22 insertions(+), 7 deletions(-)

--
1.8.1.1


2017-08-21 03:37:07

by Jun Gao

[permalink] [raw]
Subject: [PATCH v4 1/3] dt-bindings: i2c: modify information formats

From: Jun Gao <[email protected]>

Use common name MediaTek and modify the compatible information
formats of all SoCs to the same.

Signed-off-by: Jun Gao <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..9c86424 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -1,14 +1,14 @@
-* Mediatek's I2C controller
+* MediaTek's I2C controller

-The Mediatek's I2C controller is used to interface with I2C devices.
+The MediaTek's I2C controller is used to interface with I2C devices.

Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for MediaTek MT2701
+ "mediatek,mt6577-i2c": for MediaTek MT6577
+ "mediatek,mt6589-i2c": for MediaTek MT6589
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for MediaTek MT7623
+ "mediatek,mt8173-i2c": for MediaTek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1

2017-08-21 03:37:11

by Jun Gao

[permalink] [raw]
Subject: [PATCH v4 3/3] i2c: mediatek: Add i2c compatible for MediaTek MT7622

From: Jun Gao <[email protected]>

Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.

Signed-off-by: Jun Gao <[email protected]>
Reviewed-by: Yingjoe Chen <[email protected]>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..09d288c 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,10 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};

+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +194,15 @@ struct mtk_i2c {
.support_33bits = 0,
};

+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +214,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1

2017-08-21 03:37:38

by Jun Gao

[permalink] [raw]
Subject: [PATCH v4 2/3] dt-bindings: i2c: Add MediaTek MT7622 i2c binding

From: Jun Gao <[email protected]>

Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
controller, MT7622 limits message numbers to 255, and does not
support 4GB DMA mode.

Signed-off-by: Jun Gao <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index 9c86424..ff7bf37 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -7,6 +7,7 @@ Required properties:
"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for MediaTek MT2701
"mediatek,mt6577-i2c": for MediaTek MT6577
"mediatek,mt6589-i2c": for MediaTek MT6589
+ "mediatek,mt7622-i2c": for MediaTek MT7622
"mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for MediaTek MT7623
"mediatek,mt8173-i2c": for MediaTek MT8173
- reg: physical base address of the controller and dma base, length of memory
--
1.8.1.1

2017-08-23 00:36:04

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] dt-bindings: i2c: modify information formats

On Mon, Aug 21, 2017 at 11:36:52AM +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Use common name MediaTek and modify the compatible information
> formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

Acked-by: Rob Herring <[email protected]>

2017-08-23 00:36:32

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 2/3] dt-bindings: i2c: Add MediaTek MT7622 i2c binding

On Mon, Aug 21, 2017 at 11:36:53AM +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
> controller, MT7622 limits message numbers to 255, and does not
> support 4GB DMA mode.
>
> Signed-off-by: Jun Gao <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Rob Herring <[email protected]>

2017-08-27 13:31:47

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] dt-bindings: i2c: modify information formats

On Mon, Aug 21, 2017 at 11:36:52AM +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Use common name MediaTek and modify the compatible information
> formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (281.00 B)
signature.asc (833.00 B)
Download all attachments

2017-08-27 13:31:54

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v4 2/3] dt-bindings: i2c: Add MediaTek MT7622 i2c binding

On Mon, Aug 21, 2017 at 11:36:53AM +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
> controller, MT7622 limits message numbers to 255, and does not
> support 4GB DMA mode.
>
> Signed-off-by: Jun Gao <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (334.00 B)
signature.asc (833.00 B)
Download all attachments

2017-08-27 13:32:00

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] i2c: mediatek: Add i2c compatible for MediaTek MT7622

On Mon, Aug 21, 2017 at 11:36:54AM +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limits message numbers to 255, and does not support 4GB
> DMA mode.
>
> Signed-off-by: Jun Gao <[email protected]>
> Reviewed-by: Yingjoe Chen <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (381.00 B)
signature.asc (833.00 B)
Download all attachments